diff options
author | Rich Trott <rtrott@gmail.com> | 2018-08-10 14:49:21 -0700 |
---|---|---|
committer | Rich Trott <rtrott@gmail.com> | 2018-09-24 22:14:55 -0700 |
commit | b01e617dcc4cf3f38f2b4516545aaf14d352f6e4 (patch) | |
tree | 9e1ce1ae696ab6089bc914ff0880fabcde4e295e /tools | |
parent | ead5c4c054863cbc82bd2c2a8ddb31860f9e51f7 (diff) | |
download | android-node-v8-b01e617dcc4cf3f38f2b4516545aaf14d352f6e4.tar.gz android-node-v8-b01e617dcc4cf3f38f2b4516545aaf14d352f6e4.tar.bz2 android-node-v8-b01e617dcc4cf3f38f2b4516545aaf14d352f6e4.zip |
doc: require two approvals to land changes
Currently, changes require approval by one Collaborator in most cases.
However there are situations where two approvals are required. For
example, breaking changes require two approvals from TSC members. And
fast-tracking a request requires two approvals.
Additionally, although only one approval is strictly required, in
practice, we nearly always seek a second approval when there is only
one.
Lastly, concerns have been raised about (perhaps unintentionally) gaming
the one-approval system by suggesting a change to someone else, and then
approving that change when the user submits a pull request. This
resolves (or at least mitigates) that concern.
Fixes: https://github.com/nodejs/node/issues/19564
PR-URL: https://github.com/nodejs/node/pull/22255
Refs: https://github.com/nodejs/node/issues/19564
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
Reviewed-By: Bryan English <bryan@bryanenglish.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: John-David Dalton <john.david.dalton@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: George Adams <george.adams@uk.ibm.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Diffstat (limited to 'tools')
0 files changed, 0 insertions, 0 deletions