diff options
| -rw-r--r-- | COLLABORATOR_GUIDE.md | 9 | ||||
| -rw-r--r-- | GOVERNANCE.md | 12 |
2 files changed, 12 insertions, 9 deletions
diff --git a/COLLABORATOR_GUIDE.md b/COLLABORATOR_GUIDE.md index 0c03e89a07..1315e4a265 100644 --- a/COLLABORATOR_GUIDE.md +++ b/COLLABORATOR_GUIDE.md @@ -112,10 +112,11 @@ comment that explains why the PR does not require a CI run. ### Code Reviews -All pull requests must be reviewed and accepted by a Collaborator with -sufficient expertise who is able to take full responsibility for the -change. In the case of pull requests proposed by an existing -Collaborator, an additional Collaborator is required for sign-off. +At least two Collaborators must approve a pull request before the pull request +lands. (One Collaborator approval is enough if the pull request has been open +for more than 7 days.) Approving a pull request indicates that the Collaborator +accepts responsibility for the change. Approval must be from Collaborators who +are not authors of the change. In some cases, it may be necessary to summon a GitHub team to a pull request for review by @-mention. diff --git a/GOVERNANCE.md b/GOVERNANCE.md index 83d4d9b50a..40ef6e7bbe 100644 --- a/GOVERNANCE.md +++ b/GOVERNANCE.md @@ -32,11 +32,13 @@ Their privileges include but are not limited to: Modifications of the contents of the nodejs/node repository are made on a collaborative basis. Anybody with a GitHub account may propose a modification via pull request and it will be considered by the project -Collaborators. All pull requests must be reviewed and accepted by a -Collaborator with sufficient expertise who is able to take full -responsibility for the change. In the case of pull requests proposed -by an existing Collaborator, an additional Collaborator is required -for sign-off. +Collaborators. + +At least two Collaborators must approve a pull request before the pull request +lands. (One Collaborator approval is enough if the pull request has been open +for more than 7 days.) Approving a pull request indicates that the Collaborator +accepts responsibility for the change. Approval must be from Collaborators who +are not authors of the change. If one or more Collaborators oppose a proposed change, then the change cannot be accepted unless: |