diff options
| author | Rich Trott <rtrott@gmail.com> | 2018-03-19 12:13:25 -0700 |
|---|---|---|
| committer | Rich Trott <rtrott@gmail.com> | 2018-03-21 20:14:45 -0700 |
| commit | 01b74d1dda3dd2f9b5150339ae1ecffbd24e3028 (patch) | |
| tree | dbc49bf433b8f9a6fc422f8bd164df843211b323 /COLLABORATOR_GUIDE.md | |
| parent | a72bfb94ddb27b1c8cff229702f32df46233506c (diff) | |
| download | android-node-v8-01b74d1dda3dd2f9b5150339ae1ecffbd24e3028.tar.gz android-node-v8-01b74d1dda3dd2f9b5150339ae1ecffbd24e3028.tar.bz2 android-node-v8-01b74d1dda3dd2f9b5150339ae1ecffbd24e3028.zip | |
doc: require passing CI for landing code
PR-URL: https://github.com/nodejs/node/pull/19458
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Diffstat (limited to 'COLLABORATOR_GUIDE.md')
| -rw-r--r-- | COLLABORATOR_GUIDE.md | 8 |
1 files changed, 8 insertions, 0 deletions
diff --git a/COLLABORATOR_GUIDE.md b/COLLABORATOR_GUIDE.md index 882b2555d8..337b3d65ec 100644 --- a/COLLABORATOR_GUIDE.md +++ b/COLLABORATOR_GUIDE.md @@ -196,6 +196,14 @@ and must be subjected to continuous integration tests on the [project CI server](https://ci.nodejs.org/). The pull request should have a CI status indicator. +Do not land any Pull Requests without passing (green or yellow) CI runs. If you +believe any failed (red or grey) CI sub-tasks are unrelated to the change in the +Pull Request, you may re-run the sub-task to try to see if it passes. If re-runs +of all failed sub-tasks pass, it is permissible to land the Pull Request but +only if the initial failures are believed in good faith to be unrelated to the +changes in the Pull Request. Otherwise, reasonable steps must be taken to +confirm that the changes are not resulting in an unreliable test. + #### Useful CI Jobs * [`node-test-pull-request`](https://ci.nodejs.org/job/node-test-pull-request/) |