diff options
| author | Rich Trott <rtrott@gmail.com> | 2018-03-19 12:04:29 -0700 |
|---|---|---|
| committer | Rich Trott <rtrott@gmail.com> | 2018-03-21 20:14:42 -0700 |
| commit | a72bfb94ddb27b1c8cff229702f32df46233506c (patch) | |
| tree | cdd8ba5aafe99ebca6d1cc6cf786102234b9f831 /COLLABORATOR_GUIDE.md | |
| parent | f3e078fdce38cd8526e4f7f3aa657e030f141efc (diff) | |
| download | android-node-v8-a72bfb94ddb27b1c8cff229702f32df46233506c.tar.gz android-node-v8-a72bfb94ddb27b1c8cff229702f32df46233506c.tar.bz2 android-node-v8-a72bfb94ddb27b1c8cff229702f32df46233506c.zip | |
doc: simplify COLLABORATOR_GUIDE.md instructions
Remove bulleted list formatting. Only check email/name for new
contributors. Change `full name` to `name` and remove italics to avoid
incorrect implication that we need a "legal name".
PR-URL: https://github.com/nodejs/node/pull/19458
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Diffstat (limited to 'COLLABORATOR_GUIDE.md')
| -rw-r--r-- | COLLABORATOR_GUIDE.md | 9 |
1 files changed, 4 insertions, 5 deletions
diff --git a/COLLABORATOR_GUIDE.md b/COLLABORATOR_GUIDE.md index 6ffa73c2ff..882b2555d8 100644 --- a/COLLABORATOR_GUIDE.md +++ b/COLLABORATOR_GUIDE.md @@ -494,12 +494,11 @@ The TSC should serve as the final arbiter where required. one](https://github.com/nodejs/node/commit/b636ba8186) if unsure exactly how to format your commit messages. -Additionally: +Check PRs from new contributors to make sure the person's name and email address +are correct before merging. -* Double check PRs to make sure the person's _full name_ and email - address are correct before merging. -* All commits should be self-contained (meaning every commit should pass all - tests). This makes it much easier when bisecting to find a breaking change. +All commits should be self-contained, meaning every commit should pass all +tests. This makes it much easier when bisecting to find a breaking change. ### Using `git-node` |