From 01b74d1dda3dd2f9b5150339ae1ecffbd24e3028 Mon Sep 17 00:00:00 2001 From: Rich Trott Date: Mon, 19 Mar 2018 12:13:25 -0700 Subject: doc: require passing CI for landing code MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit PR-URL: https://github.com/nodejs/node/pull/19458 Reviewed-By: Colin Ihrig Reviewed-By: Michaël Zasso Reviewed-By: Richard Lau Reviewed-By: Daniel Bevenius Reviewed-By: Luigi Pinca Reviewed-By: Michael Dawson Reviewed-By: Jon Moss --- COLLABORATOR_GUIDE.md | 8 ++++++++ 1 file changed, 8 insertions(+) (limited to 'COLLABORATOR_GUIDE.md') diff --git a/COLLABORATOR_GUIDE.md b/COLLABORATOR_GUIDE.md index 882b2555d8..337b3d65ec 100644 --- a/COLLABORATOR_GUIDE.md +++ b/COLLABORATOR_GUIDE.md @@ -196,6 +196,14 @@ and must be subjected to continuous integration tests on the [project CI server](https://ci.nodejs.org/). The pull request should have a CI status indicator. +Do not land any Pull Requests without passing (green or yellow) CI runs. If you +believe any failed (red or grey) CI sub-tasks are unrelated to the change in the +Pull Request, you may re-run the sub-task to try to see if it passes. If re-runs +of all failed sub-tasks pass, it is permissible to land the Pull Request but +only if the initial failures are believed in good faith to be unrelated to the +changes in the Pull Request. Otherwise, reasonable steps must be taken to +confirm that the changes are not resulting in an unreliable test. + #### Useful CI Jobs * [`node-test-pull-request`](https://ci.nodejs.org/job/node-test-pull-request/) -- cgit v1.2.3