summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
-rw-r--r--common.gypi9
-rw-r--r--deps/v8/gypfiles/features.gypi4
2 files changed, 9 insertions, 4 deletions
diff --git a/common.gypi b/common.gypi
index cb8477aaf1..773dd3be77 100644
--- a/common.gypi
+++ b/common.gypi
@@ -45,12 +45,13 @@
# Old time default, now explicitly stated.
'v8_use_snapshot': 'true',
+ # These are more relevant for V8 internal development.
# Refs: https://github.com/nodejs/node/issues/23122
# Refs: https://github.com/nodejs/node/issues/23167
- # Enable compiler warnings when using V8_DEPRECATED apis.
- 'v8_deprecation_warnings': 1,
- # Enable compiler warnings when using V8_DEPRECATE_SOON apis.
- 'v8_imminent_deprecation_warnings': 1,
+ # Enable compiler warnings when using V8_DEPRECATED apis from V8 code.
+ 'v8_deprecation_warnings': 0,
+ # Enable compiler warnings when using V8_DEPRECATE_SOON apis from V8 code.
+ 'v8_imminent_deprecation_warnings': 0,
# Enable disassembler for `--print-code` v8 options
'v8_enable_disassembler': 1,
diff --git a/deps/v8/gypfiles/features.gypi b/deps/v8/gypfiles/features.gypi
index 855a7a5d2f..7e5af8883a 100644
--- a/deps/v8/gypfiles/features.gypi
+++ b/deps/v8/gypfiles/features.gypi
@@ -164,9 +164,13 @@
}],
['v8_deprecation_warnings==1', {
'defines': ['V8_DEPRECATION_WARNINGS',],
+ },{
+ 'defines!': ['V8_DEPRECATION_WARNINGS',],
}],
['v8_imminent_deprecation_warnings==1', {
'defines': ['V8_IMMINENT_DEPRECATION_WARNINGS',],
+ },{
+ 'defines!': ['V8_IMMINENT_DEPRECATION_WARNINGS',],
}],
['v8_enable_i18n_support==1', {
'defines': ['V8_INTL_SUPPORT',],