diff options
| author | Refael Ackermann <refack@gmail.com> | 2019-01-08 10:08:54 -0500 |
|---|---|---|
| committer | Anna Henningsen <anna@addaleax.net> | 2019-01-14 17:44:13 +0100 |
| commit | d1b7193428f6ed244e3937f718719312749b465e (patch) | |
| tree | fe69504a341b3c0a674bd46480c2be6578747f3a | |
| parent | eb5aab2c46d7c92165de84023b242be079e6b711 (diff) | |
| download | android-node-v8-d1b7193428f6ed244e3937f718719312749b465e.tar.gz android-node-v8-d1b7193428f6ed244e3937f718719312749b465e.tar.bz2 android-node-v8-d1b7193428f6ed244e3937f718719312749b465e.zip | |
deps,v8: silence V8 self-deprecation warnings
PR-URL: https://github.com/nodejs/node/pull/25394
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yang Guo <yangguo@chromium.org>
| -rw-r--r-- | common.gypi | 9 | ||||
| -rw-r--r-- | deps/v8/gypfiles/features.gypi | 4 |
2 files changed, 9 insertions, 4 deletions
diff --git a/common.gypi b/common.gypi index cb8477aaf1..773dd3be77 100644 --- a/common.gypi +++ b/common.gypi @@ -45,12 +45,13 @@ # Old time default, now explicitly stated. 'v8_use_snapshot': 'true', + # These are more relevant for V8 internal development. # Refs: https://github.com/nodejs/node/issues/23122 # Refs: https://github.com/nodejs/node/issues/23167 - # Enable compiler warnings when using V8_DEPRECATED apis. - 'v8_deprecation_warnings': 1, - # Enable compiler warnings when using V8_DEPRECATE_SOON apis. - 'v8_imminent_deprecation_warnings': 1, + # Enable compiler warnings when using V8_DEPRECATED apis from V8 code. + 'v8_deprecation_warnings': 0, + # Enable compiler warnings when using V8_DEPRECATE_SOON apis from V8 code. + 'v8_imminent_deprecation_warnings': 0, # Enable disassembler for `--print-code` v8 options 'v8_enable_disassembler': 1, diff --git a/deps/v8/gypfiles/features.gypi b/deps/v8/gypfiles/features.gypi index 855a7a5d2f..7e5af8883a 100644 --- a/deps/v8/gypfiles/features.gypi +++ b/deps/v8/gypfiles/features.gypi @@ -164,9 +164,13 @@ }], ['v8_deprecation_warnings==1', { 'defines': ['V8_DEPRECATION_WARNINGS',], + },{ + 'defines!': ['V8_DEPRECATION_WARNINGS',], }], ['v8_imminent_deprecation_warnings==1', { 'defines': ['V8_IMMINENT_DEPRECATION_WARNINGS',], + },{ + 'defines!': ['V8_IMMINENT_DEPRECATION_WARNINGS',], }], ['v8_enable_i18n_support==1', { 'defines': ['V8_INTL_SUPPORT',], |