diff options
| author | Ben Noordhuis <info@bnoordhuis.nl> | 2017-10-24 13:01:50 +0200 |
|---|---|---|
| committer | Michael Dawson <michael_dawson@ca.ibm.com> | 2017-10-25 17:22:04 -0400 |
| commit | e714c42eabb265d7f8a230de595eef12fddd58c9 (patch) | |
| tree | 2118c6e8db75c750b04800d162e18819d4104855 /tools | |
| parent | a3998817739e22214fe65c3d122deac43bb47b01 (diff) | |
| download | android-node-v8-e714c42eabb265d7f8a230de595eef12fddd58c9.tar.gz android-node-v8-e714c42eabb265d7f8a230de595eef12fddd58c9.tar.bz2 android-node-v8-e714c42eabb265d7f8a230de595eef12fddd58c9.zip | |
build: fix npm install with --shared
The npm install rules had a hidden dependency on the `node` binary
install rule creating the `$PREFIX/bin` directory.
Because with `./configure --shared` no binary is created, the rule
subsequently failed. Fix that by creating the directory before
creating the symlinks to the npm and npx scripts.
(Whether it makes sense to install npm without a `node` binary is
a separate question. This commit is not taking positions. :-))
Regression introduced in commit ed8c89a ("build: fix shared installing
target") which, as the commit log indicates, was itself a bug fix for
the `./configure --shared` install.
PR-URL: https://github.com/nodejs/node/pull/16438
Fixes: https://github.com/nodejs/node/issues/16437
Ref: https://github.com/nodejs/node/pull/15148
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Diffstat (limited to 'tools')
| -rwxr-xr-x | tools/install.py | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/tools/install.py b/tools/install.py index d6793755cb..be2bab5463 100755 --- a/tools/install.py +++ b/tools/install.py @@ -33,6 +33,7 @@ def try_unlink(path): def try_symlink(source_path, link_path): print 'symlinking %s -> %s' % (source_path, link_path) try_unlink(link_path) + try_mkdir_r(os.path.dirname(link_path)) os.symlink(source_path, link_path) def try_mkdir_r(path): |