diff options
author | Rich Trott <rtrott@gmail.com> | 2017-07-30 13:46:34 -0700 |
---|---|---|
committer | Rich Trott <rtrott@gmail.com> | 2017-08-02 09:27:35 -0700 |
commit | e506bcd899b3530ec69bdc00d5bac469b5753081 (patch) | |
tree | 37d68bdd1bb28bf2be19466adfe7f3941fb581cd /tools | |
parent | 548cc72f6604b5bcf93dfcb9033b0c7c3fba1cdf (diff) | |
download | android-node-v8-e506bcd899b3530ec69bdc00d5bac469b5753081.tar.gz android-node-v8-e506bcd899b3530ec69bdc00d5bac469b5753081.tar.bz2 android-node-v8-e506bcd899b3530ec69bdc00d5bac469b5753081.zip |
tools: replace assert-throw-arguments custom lint
The functionality of ESLint custom rule assert-throws-arguments can be
replaced with no-restricted-syntax entries.
PR-URL: https://github.com/nodejs/node/pull/14547
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Diffstat (limited to 'tools')
-rw-r--r-- | tools/eslint-rules/assert-throws-arguments.js | 60 |
1 files changed, 0 insertions, 60 deletions
diff --git a/tools/eslint-rules/assert-throws-arguments.js b/tools/eslint-rules/assert-throws-arguments.js deleted file mode 100644 index 3b51188c0c..0000000000 --- a/tools/eslint-rules/assert-throws-arguments.js +++ /dev/null @@ -1,60 +0,0 @@ -/** - * @fileoverview Check that assert.throws is never called with a string as - * second argument. - * @author Michaël Zasso - */ -'use strict'; - -//------------------------------------------------------------------------------ -// Rule Definition -//------------------------------------------------------------------------------ - -function checkThrowsArguments(context, node) { - if (node.callee.type === 'MemberExpression' && - node.callee.object.name === 'assert' && - node.callee.property.name === 'throws') { - const args = node.arguments; - if (args.length > 3) { - context.report({ - message: 'Too many arguments', - node: node - }); - } else if (args.length > 1) { - const error = args[1]; - if (error.type === 'Literal' && typeof error.value === 'string' || - error.type === 'TemplateLiteral') { - context.report({ - message: 'Unexpected string as second argument', - node: error - }); - } - } else { - if (context.options[0].requireTwo) { - context.report({ - message: 'Expected at least two arguments', - node: node - }); - } - } - } -} - -module.exports = { - meta: { - schema: [ - { - type: 'object', - properties: { - requireTwo: { - type: 'boolean' - } - } - } - ] - }, - create: function(context) { - return { - CallExpression: (node) => checkThrowsArguments(context, node) - }; - } -}; |