diff options
| author | Christian Clauss <cclauss@me.com> | 2019-10-27 13:30:30 +0100 |
|---|---|---|
| committer | cclauss <cclauss@me.com> | 2019-10-31 22:10:40 +0100 |
| commit | db1aab9df6bfad1d1601d474a1f978bedd9382d5 (patch) | |
| tree | beb4c8546481d5a5e1cae6fcff6e04e24217a70f /tools | |
| parent | 61d61448a91b74f889c33cad54e95f8fdb9d2c61 (diff) | |
| download | android-node-v8-db1aab9df6bfad1d1601d474a1f978bedd9382d5.tar.gz android-node-v8-db1aab9df6bfad1d1601d474a1f978bedd9382d5.tar.bz2 android-node-v8-db1aab9df6bfad1d1601d474a1f978bedd9382d5.zip | |
tools: undefined name opts -> args in gyptest.py
```
./tools/gyp/gyptest.py:61:47: F821 undefined name 'opts'
extra_path = [os.path.abspath(p) for p in opts.path]
^
```
`opts.path` is an undefined name in this context while `args.path` is
used on the preceding line and is defined on line 48. Undefined names
have the potential to raise `NameError` at runtime which will halt the
script.
PR-URL: https://github.com/nodejs/node/pull/30144
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Diffstat (limited to 'tools')
| -rwxr-xr-x | tools/gyp/gyptest.py | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/tools/gyp/gyptest.py b/tools/gyp/gyptest.py index 9930e78c7b..1a9ffca7a1 100755 --- a/tools/gyp/gyptest.py +++ b/tools/gyp/gyptest.py @@ -58,7 +58,7 @@ def main(argv=None): os.chdir(args.chdir) if args.path: - extra_path = [os.path.abspath(p) for p in opts.path] + extra_path = [os.path.abspath(p) for p in args.path] extra_path = os.pathsep.join(extra_path) os.environ['PATH'] = extra_path + os.pathsep + os.environ['PATH'] |