diff options
author | Rich Trott <rtrott@gmail.com> | 2016-02-13 13:57:34 -0800 |
---|---|---|
committer | Rich Trott <rtrott@gmail.com> | 2016-02-18 10:13:03 -0800 |
commit | d3c3a928c3a2f9e961881b47ef0796e57ae8d429 (patch) | |
tree | 90f11bae9e6ef98e60f8d90c1db56ba73be306ac /tools | |
parent | 32f6098eefc7404ef74ca59dfdfceebb009f6f53 (diff) | |
download | android-node-v8-d3c3a928c3a2f9e961881b47ef0796e57ae8d429.tar.gz android-node-v8-d3c3a928c3a2f9e961881b47ef0796e57ae8d429.tar.bz2 android-node-v8-d3c3a928c3a2f9e961881b47ef0796e57ae8d429.zip |
tools: remove obsolete lint rules
We are about to upgrade from ESlint 1 to ESLint 2. Remove lint rules
that will not exist in ESLint 2.
PR-URL: https://github.com/nodejs/node/pull/5214
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: jbergstroem - Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Diffstat (limited to 'tools')
-rw-r--r-- | tools/eslint-rules/new-with-error.js | 5 | ||||
-rw-r--r-- | tools/eslint-rules/require-buffer.js | 19 | ||||
-rw-r--r-- | tools/eslint-rules/required-modules.js | 5 |
3 files changed, 11 insertions, 18 deletions
diff --git a/tools/eslint-rules/new-with-error.js b/tools/eslint-rules/new-with-error.js index b0f550db2f..655f34bf08 100644 --- a/tools/eslint-rules/new-with-error.js +++ b/tools/eslint-rules/new-with-error.js @@ -24,11 +24,6 @@ module.exports = function(context) { module.exports.schema = { 'type': 'array', - 'items': [ - { - 'enum': [0, 1, 2] - } - ], 'additionalItems': { 'type': 'string' }, diff --git a/tools/eslint-rules/require-buffer.js b/tools/eslint-rules/require-buffer.js index 4fec765d7e..c9818cb758 100644 --- a/tools/eslint-rules/require-buffer.js +++ b/tools/eslint-rules/require-buffer.js @@ -1,16 +1,19 @@ 'use strict'; -const msg = 'Use const Buffer = require(\'buffer\').Buffer; ' + - 'at the beginning of this file'; - module.exports = function(context) { + function flagIt(reference) { + const msg = 'Use const Buffer = require(\'buffer\').Buffer; ' + + 'at the beginning of this file'; + context.report(reference.identifier, msg); + } + return { 'Program:exit': function() { - context.getScope().through.forEach(function(ref) { - if (ref.identifier.name === 'Buffer') { - context.report(ref.identifier, msg); - } - }); + const globalScope = context.getScope(); + const variable = globalScope.set.get('Buffer'); + if (variable) { + variable.references.forEach(flagIt); + } } }; }; diff --git a/tools/eslint-rules/required-modules.js b/tools/eslint-rules/required-modules.js index 94ef1e2ac0..3e4a8e8aad 100644 --- a/tools/eslint-rules/required-modules.js +++ b/tools/eslint-rules/required-modules.js @@ -92,11 +92,6 @@ module.exports = function(context) { module.exports.schema = { 'type': 'array', - 'items': [ - { - 'enum': [0, 1, 2] - } - ], 'additionalItems': { 'type': 'string' }, |