diff options
| author | Ben Noordhuis <info@bnoordhuis.nl> | 2019-04-21 09:50:59 +0200 |
|---|---|---|
| committer | Daniel Bevenius <daniel.bevenius@gmail.com> | 2019-04-24 10:22:50 +0200 |
| commit | a88700abd54f56714cdad5c0c70d111af89af173 (patch) | |
| tree | 11feab054294bba28caa7bef5cf4e97ae4352947 /tools | |
| parent | fb3f6005c037f9af8f435edd0d1f407266af2916 (diff) | |
| download | android-node-v8-a88700abd54f56714cdad5c0c70d111af89af173.tar.gz android-node-v8-a88700abd54f56714cdad5c0c70d111af89af173.tar.bz2 android-node-v8-a88700abd54f56714cdad5c0c70d111af89af173.zip | |
tools: fix use-after-free mkcodecache warning
Call `v8::Platform::ShutdownPlatform()` to fix a Coverity warning about
the `v8::Platform` instance being deleted when it's still in use.
PR-URL: https://github.com/nodejs/node/pull/27332
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Diffstat (limited to 'tools')
| -rw-r--r-- | tools/code_cache/mkcodecache.cc | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/tools/code_cache/mkcodecache.cc b/tools/code_cache/mkcodecache.cc index 24f7e05e1f..defa1462ce 100644 --- a/tools/code_cache/mkcodecache.cc +++ b/tools/code_cache/mkcodecache.cc @@ -58,5 +58,6 @@ int main(int argc, char* argv[]) { out.close(); } + v8::V8::ShutdownPlatform(); return 0; } |