diff options
| author | Anna Henningsen <anna@addaleax.net> | 2019-09-20 23:42:31 +0200 |
|---|---|---|
| committer | Rich Trott <rtrott@gmail.com> | 2019-09-24 21:35:40 -0700 |
| commit | 7899a96e66a2f9bb836ca80d8264954848633a3d (patch) | |
| tree | d53d1b85aa621e6e4a518599f1eed4b4860bed25 /tools | |
| parent | 355f2ad466dc155cae233e3990d19b094dd72b46 (diff) | |
| download | android-node-v8-7899a96e66a2f9bb836ca80d8264954848633a3d.tar.gz android-node-v8-7899a96e66a2f9bb836ca80d8264954848633a3d.tar.bz2 android-node-v8-7899a96e66a2f9bb836ca80d8264954848633a3d.zip | |
worker: keep allocators for transferred SAB instances alive longer
Keep the `ArrayBuffer::Allocator` behind a `SharedArrayBuffer` instance
alive for at least as long as the receiving Isolate lives, if the
`SharedArrayBuffer` instance isn’t already destroyed through GC.
This is to work around the fact that V8 7.9 started refactoring
how backing stores for `SharedArrayBuffer` instances work, changing
the timing of the call that releases the backing store to be
during Isolate disposal.
The flag added to the test is optional but helps verify that the
backing store is actually free’d at the end of the test and does not
leak memory.
Fixes: https://github.com/nodejs/node-v8/issues/115
PR-URL: https://github.com/nodejs/node/pull/29637
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Diffstat (limited to 'tools')
0 files changed, 0 insertions, 0 deletions