diff options
| author | Chris Young <chris.young@gotinder.com> | 2017-09-13 17:37:32 -0700 |
|---|---|---|
| committer | Ruben Bridgewater <ruben@bridgewater.de> | 2017-09-19 16:10:19 -0300 |
| commit | 2b7b9f24d9f3e0fcd848ae9b6c5cb94202935571 (patch) | |
| tree | 8ff285a6cb9b2be831d7b37648652a67fe068fc2 /tools | |
| parent | 19766547fa2a783b8e7472c31ad246ee118230ee (diff) | |
| download | android-node-v8-2b7b9f24d9f3e0fcd848ae9b6c5cb94202935571.tar.gz android-node-v8-2b7b9f24d9f3e0fcd848ae9b6c5cb94202935571.tar.bz2 android-node-v8-2b7b9f24d9f3e0fcd848ae9b6c5cb94202935571.zip | |
doc: prevent displaying empty version picker
PR-URL: https://github.com/nodejs/node/pull/15420
Fixes: https://github.com/nodejs/node/issues/15396
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Diffstat (limited to 'tools')
| -rw-r--r-- | tools/doc/html.js | 12 |
1 files changed, 10 insertions, 2 deletions
diff --git a/tools/doc/html.js b/tools/doc/html.js index 3373750a8d..0c15162c4c 100644 --- a/tools/doc/html.js +++ b/tools/doc/html.js @@ -232,9 +232,17 @@ function altDocs(filename) { return html + '</a></li>'; } - const lis = (vs) => vs.filter(lte).map(li).join('\n'); + const lis = versions.filter(lte).map(li).join('\n'); - return `<ol class="version-picker">${lis(versions)}</ol>`; + if (!lis.length) + return ''; + + return ` + <li class="version-picker"> + <a href="#">View another version <span>▼</span></a> + <ol class="version-picker">${lis}</ol> + </li> + `; } // handle general body-text replacements |