diff options
author | Rich Trott <rtrott@gmail.com> | 2018-04-24 14:20:31 -0700 |
---|---|---|
committer | Rich Trott <rtrott@gmail.com> | 2018-04-26 19:42:59 -0700 |
commit | 169756b15dc8f6c2974a8ef3f095c055dcd47159 (patch) | |
tree | 9fc9198d31ecde8452e432564643bae6376e60bd /tools | |
parent | 13001035340d6d3fb173fef4a1db42ba70f61720 (diff) | |
download | android-node-v8-169756b15dc8f6c2974a8ef3f095c055dcd47159.tar.gz android-node-v8-169756b15dc8f6c2974a8ef3f095c055dcd47159.tar.bz2 android-node-v8-169756b15dc8f6c2974a8ef3f095c055dcd47159.zip |
tools: show stdout/stderr for timed out tests
When a test times out, the contents of stdout and stderr can often be
highly valuable in debugging. Provide that information.
Refs: https://github.com/nodejs/node/issues/19906#issuecomment-382073888
PR-URL: https://github.com/nodejs/node/pull/20260
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Diffstat (limited to 'tools')
-rwxr-xr-x | tools/test.py | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/tools/test.py b/tools/test.py index 9bee9c2a22..e652e47092 100755 --- a/tools/test.py +++ b/tools/test.py @@ -333,7 +333,7 @@ class TapProgressIndicator(SimpleProgressIndicator): (total_seconds, duration.microseconds / 1000)) if self.severity is not 'ok' or self.traceback is not '': if output.HasTimedOut(): - self.traceback = 'timeout' + self.traceback = 'timeout\n' + output.output.stdout + output.output.stderr self._printDiagnostic() logger.info(' ...') |