diff options
author | Rich Trott <rtrott@gmail.com> | 2016-09-09 20:37:32 -0700 |
---|---|---|
committer | Rich Trott <rtrott@gmail.com> | 2016-09-12 21:12:03 -0700 |
commit | d4061a63142004eee4ffc3de5fca7286cd330090 (patch) | |
tree | 911ce66597df19d721e2700ce70d645b041c6e0e /tools/eslint-rules | |
parent | 2da2625ad16b09c25d7622c91ffe1d940e44e41a (diff) | |
download | android-node-v8-d4061a63142004eee4ffc3de5fca7286cd330090.tar.gz android-node-v8-d4061a63142004eee4ffc3de5fca7286cd330090.tar.bz2 android-node-v8-d4061a63142004eee4ffc3de5fca7286cd330090.zip |
tools: replace custom ESLint rule with built-in
ESLint 3.5.0 introduces a `no-restricted-properties` rule. Replace our
custom `no-deepEqual` rule with this rule.
PR-URL: https://github.com/nodejs/node/pull/8478
Reviewed-By: James M Snell <jasnell@gmail.com>
Diffstat (limited to 'tools/eslint-rules')
-rw-r--r-- | tools/eslint-rules/no-deepEqual.js | 32 |
1 files changed, 0 insertions, 32 deletions
diff --git a/tools/eslint-rules/no-deepEqual.js b/tools/eslint-rules/no-deepEqual.js deleted file mode 100644 index 46341d7d92..0000000000 --- a/tools/eslint-rules/no-deepEqual.js +++ /dev/null @@ -1,32 +0,0 @@ -/** - * @fileoverview Prohibit use of assert.deepEqual() - * @author Rich Trott - * - * This rule is imperfect, but will find the most common forms of - * assert.deepEqual() usage. - */ -'use strict'; - -//------------------------------------------------------------------------------ -// Rule Definition -//------------------------------------------------------------------------------ - -const msg = 'assert.deepEqual() disallowed. Use assert.deepStrictEqual()'; - -function isAssert(node) { - return node.callee.object && node.callee.object.name === 'assert'; -} - -function isDeepEqual(node) { - return node.callee.property && node.callee.property.name === 'deepEqual'; -} - -module.exports = function(context) { - return { - 'CallExpression': function(node) { - if (isAssert(node) && isDeepEqual(node)) { - context.report(node, msg); - } - } - }; -}; |