From d4061a63142004eee4ffc3de5fca7286cd330090 Mon Sep 17 00:00:00 2001 From: Rich Trott Date: Fri, 9 Sep 2016 20:37:32 -0700 Subject: tools: replace custom ESLint rule with built-in ESLint 3.5.0 introduces a `no-restricted-properties` rule. Replace our custom `no-deepEqual` rule with this rule. PR-URL: https://github.com/nodejs/node/pull/8478 Reviewed-By: James M Snell --- tools/eslint-rules/no-deepEqual.js | 32 -------------------------------- 1 file changed, 32 deletions(-) delete mode 100644 tools/eslint-rules/no-deepEqual.js (limited to 'tools/eslint-rules') diff --git a/tools/eslint-rules/no-deepEqual.js b/tools/eslint-rules/no-deepEqual.js deleted file mode 100644 index 46341d7d92..0000000000 --- a/tools/eslint-rules/no-deepEqual.js +++ /dev/null @@ -1,32 +0,0 @@ -/** - * @fileoverview Prohibit use of assert.deepEqual() - * @author Rich Trott - * - * This rule is imperfect, but will find the most common forms of - * assert.deepEqual() usage. - */ -'use strict'; - -//------------------------------------------------------------------------------ -// Rule Definition -//------------------------------------------------------------------------------ - -const msg = 'assert.deepEqual() disallowed. Use assert.deepStrictEqual()'; - -function isAssert(node) { - return node.callee.object && node.callee.object.name === 'assert'; -} - -function isDeepEqual(node) { - return node.callee.property && node.callee.property.name === 'deepEqual'; -} - -module.exports = function(context) { - return { - 'CallExpression': function(node) { - if (isAssert(node) && isDeepEqual(node)) { - context.report(node, msg); - } - } - }; -}; -- cgit v1.2.3