test: rename test-regress-GH-784.js

Rename the test appropriately alongside mentioning the subsystem
Also, make a few basic changes to make sure the test conforms
to the standard test structure

Refs: https://github.com/nodejs/node/issues/19105
Refs: https://github.com/nodejs/node/blob/master/doc/guides/writing-tests.md#test-structure

PR-URL: https://github.com/nodejs/node/pull/19161
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>

1 files changed, 155 insertions, 0 deletions

diff --git a/test/sequential/test-http-econnrefused.js b/test/sequential/test-http-econnrefused.js
new file mode 100644
index 0000000000..ff4508963b
--- /dev/null
+++ b/test/sequential/test-http-econnrefused.js
@@ -0,0 +1,155 @@
+// Copyright Joyent, Inc. and other Node contributors.
+//
+// Permission is hereby granted, free of charge, to any person obtaining a
+// copy of this software and associated documentation files (the
+// "Software"), to deal in the Software without restriction, including
+// without limitation the rights to use, copy, modify, merge, publish,
+// distribute, sublicense, and/or sell copies of the Software, and to permit
+// persons to whom the Software is furnished to do so, subject to the
+// following conditions:
+//
+// The above copyright notice and this permission notice shall be included
+// in all copies or substantial portions of the Software.
+//
+// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
+// OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
+// MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN
+// NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM,
+// DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR
+// OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
+// USE OR OTHER DEALINGS IN THE SOFTWARE.
+
+'use strict';
+const common = require('../common');
+
+// The test works by making a total of 8 requests to the server.  The first
+// two are made with the server off - they should come back as ECONNREFUSED.
+// The next two are made with server on - they should come back successful.
+// The next two are made with the server off - and so on.  Without the fix
+// we were experiencing parse errors instead of ECONNREFUSED.
+// https://github.com/nodejs/node-v0.x-archive/issues/784
+
+const http = require('http');
+const assert = require('assert');
+
+
+const server = http.createServer(function(req, res) {
+  let body = '';
+
+  req.setEncoding('utf8');
+  req.on('data', function(chunk) {
+    body += chunk;
+  });
+
+  req.on('end', function() {
+    assert.strictEqual(body, 'PING');
+    res.writeHead(200);
+    res.end('PONG');
+  });
+});
+
+
+server.on('listening', pingping);
+
+
+function serverOn() {
+  console.error('Server ON');
+  server.listen(common.PORT);
+}
+
+
+function serverOff() {
+  console.error('Server OFF');
+  server.close();
+  pingping();
+}
+
+const responses = [];
+
+
+function afterPing(result) {
+  responses.push(result);
+  console.error(`afterPing. responses.length = ${responses.length}`);
+  const ECONNREFUSED_RE = /ECONNREFUSED/;
+  const successRE = /success/;
+  switch (responses.length) {
+    case 2:
+      assert.ok(ECONNREFUSED_RE.test(responses[0]));
+      assert.ok(ECONNREFUSED_RE.test(responses[1]));
+      serverOn();
+      break;
+
+    case 4:
+      assert.ok(successRE.test(responses[2]));
+      assert.ok(successRE.test(responses[3]));
+      serverOff();
+      break;
+
+    case 6:
+      assert.ok(ECONNREFUSED_RE.test(responses[4]));
+      assert.ok(ECONNREFUSED_RE.test(responses[5]));
+      serverOn();
+      break;
+
+    case 8:
+      assert.ok(successRE.test(responses[6]));
+      assert.ok(successRE.test(responses[7]));
+      server.close();
+      // we should go to process.on('exit') from here.
+      break;
+  }
+}
+
+
+function ping() {
+  console.error('making req');
+
+  const opt = {
+    port: common.PORT,
+    path: '/ping',
+    method: 'POST'
+  };
+
+  const req = http.request(opt, function(res) {
+    let body = '';
+
+    res.setEncoding('utf8');
+    res.on('data', function(chunk) {
+      body += chunk;
+    });
+
+    res.on('end', function() {
+      assert.strictEqual(body, 'PONG');
+      assert.ok(!hadError);
+      gotEnd = true;
+      afterPing('success');
+    });
+  });
+
+  req.end('PING');
+
+  let gotEnd = false;
+  let hadError = false;
+
+  req.on('error', function(error) {
+    console.log(`Error making ping req: ${error}`);
+    hadError = true;
+    assert.ok(!gotEnd);
+    afterPing(error.message);
+  });
+}
+
+
+function pingping() {
+  ping();
+  ping();
+}
+
+pingping();
+
+process.on('exit', function() {
+  console.error("process.on('exit')");
+  console.error(responses);
+
+  assert.strictEqual(responses.length, 8);
+});