diff options
author | Ujjwal Sharma <usharma1998@gmail.com> | 2018-03-06 19:39:10 +0530 |
---|---|---|
committer | Gus Caplan <me@gus.host> | 2018-03-08 10:37:37 -0600 |
commit | a73a071a05a213a9c681509c8fa72feda388142a (patch) | |
tree | b983c567086945a4febaac2abf6432fcab1cd291 | |
parent | db30142ececd4ece2039008e665b39c4519f2143 (diff) | |
download | android-node-v8-a73a071a05a213a9c681509c8fa72feda388142a.tar.gz android-node-v8-a73a071a05a213a9c681509c8fa72feda388142a.tar.bz2 android-node-v8-a73a071a05a213a9c681509c8fa72feda388142a.zip |
test: rename test-regress-GH-784.js
Rename the test appropriately alongside mentioning the subsystem
Also, make a few basic changes to make sure the test conforms
to the standard test structure
Refs: https://github.com/nodejs/node/issues/19105
Refs: https://github.com/nodejs/node/blob/master/doc/guides/writing-tests.md#test-structure
PR-URL: https://github.com/nodejs/node/pull/19161
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
-rw-r--r-- | test/sequential/test-http-econnrefused.js (renamed from test/sequential/test-regress-GH-784.js) | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/test/sequential/test-regress-GH-784.js b/test/sequential/test-http-econnrefused.js index 4b285020d4..ff4508963b 100644 --- a/test/sequential/test-regress-GH-784.js +++ b/test/sequential/test-http-econnrefused.js @@ -20,15 +20,15 @@ // USE OR OTHER DEALINGS IN THE SOFTWARE. 'use strict'; -// Regression test for GH-784 -// https://github.com/joyent/node/issues/784 -// +const common = require('../common'); + // The test works by making a total of 8 requests to the server. The first // two are made with the server off - they should come back as ECONNREFUSED. // The next two are made with server on - they should come back successful. // The next two are made with the server off - and so on. Without the fix -// we were experiencing parse errors and instead of ECONNREFUSED. -const common = require('../common'); +// we were experiencing parse errors instead of ECONNREFUSED. +// https://github.com/nodejs/node-v0.x-archive/issues/784 + const http = require('http'); const assert = require('assert'); |