diff options
| author | Rich Trott <rtrott@gmail.com> | 2019-01-06 19:36:14 -0800 |
|---|---|---|
| committer | Rich Trott <rtrott@gmail.com> | 2019-01-09 13:50:17 -0800 |
| commit | 284b20bf75ced9f29161275ae3b0d6eac6abe5ef (patch) | |
| tree | 9fbae762d06593dce74e9670241044dab53f9ca4 /test/pummel | |
| parent | c2d8a54474624f9894683a7d1e6b297f055487e5 (diff) | |
| download | android-node-v8-284b20bf75ced9f29161275ae3b0d6eac6abe5ef.tar.gz android-node-v8-284b20bf75ced9f29161275ae3b0d6eac6abe5ef.tar.bz2 android-node-v8-284b20bf75ced9f29161275ae3b0d6eac6abe5ef.zip | |
test: fix test/pummel/test-fs-largefile.js
test-fs-largefile.js calls `fs.close()` without a callback which results
in an error as of Node.js 10.0.0. Add a `common.mustCall()` callback so
the test passes again.
PR-URL: https://github.com/nodejs/node/pull/25372
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Diffstat (limited to 'test/pummel')
| -rw-r--r-- | test/pummel/test-fs-largefile.js | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/test/pummel/test-fs-largefile.js b/test/pummel/test-fs-largefile.js index 2e9dda0495..8200543b9a 100644 --- a/test/pummel/test-fs-largefile.js +++ b/test/pummel/test-fs-largefile.js @@ -20,7 +20,7 @@ // USE OR OTHER DEALINGS IN THE SOFTWARE. 'use strict'; -require('../common'); +const common = require('../common'); const assert = require('assert'); const fs = require('fs'); @@ -46,7 +46,7 @@ assert.strictEqual(readBuf[0], 0); // Verify that floating point positions do not throw. fs.writeSync(fd, writeBuf, 0, writeBuf.length, 42.000001); -fs.close(fd); +fs.close(fd, common.mustCall()); // Normally, we don't clean up tmp files at the end of a test, but we'll make an // exception for a 5 GB file. |