From 284b20bf75ced9f29161275ae3b0d6eac6abe5ef Mon Sep 17 00:00:00 2001 From: Rich Trott Date: Sun, 6 Jan 2019 19:36:14 -0800 Subject: test: fix test/pummel/test-fs-largefile.js MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit test-fs-largefile.js calls `fs.close()` without a callback which results in an error as of Node.js 10.0.0. Add a `common.mustCall()` callback so the test passes again. PR-URL: https://github.com/nodejs/node/pull/25372 Reviewed-By: James M Snell Reviewed-By: Daijiro Wachi Reviewed-By: Colin Ihrig Reviewed-By: Anto Aravinth Reviewed-By: Anna Henningsen Reviewed-By: Luigi Pinca Reviewed-By: Tobias Nießen --- test/pummel/test-fs-largefile.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'test/pummel') diff --git a/test/pummel/test-fs-largefile.js b/test/pummel/test-fs-largefile.js index 2e9dda0495..8200543b9a 100644 --- a/test/pummel/test-fs-largefile.js +++ b/test/pummel/test-fs-largefile.js @@ -20,7 +20,7 @@ // USE OR OTHER DEALINGS IN THE SOFTWARE. 'use strict'; -require('../common'); +const common = require('../common'); const assert = require('assert'); const fs = require('fs'); @@ -46,7 +46,7 @@ assert.strictEqual(readBuf[0], 0); // Verify that floating point positions do not throw. fs.writeSync(fd, writeBuf, 0, writeBuf.length, 42.000001); -fs.close(fd); +fs.close(fd, common.mustCall()); // Normally, we don't clean up tmp files at the end of a test, but we'll make an // exception for a 5 GB file. -- cgit v1.2.3