diff options
author | Ulmanb <barulman@gmail.com> | 2017-11-20 20:24:15 +0200 |
---|---|---|
committer | Benjamin Gruenbaum <benji@peer5.com> | 2017-12-20 09:52:38 +0200 |
commit | 3bb6f07d528905d2ba6b9a4710890bc74350d7f0 (patch) | |
tree | d57e33c03c92336c051ea67dd569648d07e4746f /test/parallel/test-event-emitter-method-names.js | |
parent | 482c27e13d46a574e801d21fd637ad06945b9d36 (diff) | |
download | android-node-v8-3bb6f07d528905d2ba6b9a4710890bc74350d7f0.tar.gz android-node-v8-3bb6f07d528905d2ba6b9a4710890bc74350d7f0.tar.bz2 android-node-v8-3bb6f07d528905d2ba6b9a4710890bc74350d7f0.zip |
events: add off alias to removeListener
Add `off` as an alias for `removeListener`
PR-URL: https://github.com/nodejs/node/pull/17156
Refs: https://github.com/nodejs/node/issues/17102
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jan Krems <jan.krems@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Benedikt Meurer <benedikt.meurer@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Michaƫl Zasso <targos@protonmail.com>
Reviewed-By: Khaidi Chu <i@2333.moe>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Diffstat (limited to 'test/parallel/test-event-emitter-method-names.js')
-rw-r--r-- | test/parallel/test-event-emitter-method-names.js | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/test/parallel/test-event-emitter-method-names.js b/test/parallel/test-event-emitter-method-names.js index c74b88aff7..684024d027 100644 --- a/test/parallel/test-event-emitter-method-names.js +++ b/test/parallel/test-event-emitter-method-names.js @@ -27,8 +27,9 @@ const events = require('events'); const E = events.EventEmitter.prototype; assert.strictEqual(E.constructor.name, 'EventEmitter'); assert.strictEqual(E.on, E.addListener); // Same method. +assert.strictEqual(E.off, E.removeListener); // Same method. Object.getOwnPropertyNames(E).forEach(function(name) { - if (name === 'constructor' || name === 'on') return; + if (name === 'constructor' || name === 'on' || name === 'off') return; if (typeof E[name] !== 'function') return; assert.strictEqual(E[name].name, name); }); |