From 3bb6f07d528905d2ba6b9a4710890bc74350d7f0 Mon Sep 17 00:00:00 2001 From: Ulmanb Date: Mon, 20 Nov 2017 20:24:15 +0200 Subject: events: add off alias to removeListener MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Add `off` as an alias for `removeListener` PR-URL: https://github.com/nodejs/node/pull/17156 Refs: https://github.com/nodejs/node/issues/17102 Reviewed-By: Anatoli Papirovski Reviewed-By: Benjamin Gruenbaum Reviewed-By: Matteo Collina Reviewed-By: Franziska Hinkelmann Reviewed-By: Fedor Indutny Reviewed-By: James M Snell Reviewed-By: Jan Krems Reviewed-By: Evan Lucas Reviewed-By: Sakthipriyan Vairamani Reviewed-By: Benedikt Meurer Reviewed-By: Anna Henningsen Reviewed-By: Timothy Gu Reviewed-By: Michaël Zasso Reviewed-By: Khaidi Chu Reviewed-By: Yuta Hiroto Reviewed-By: Gireesh Punathil Reviewed-By: Ruben Bridgewater --- test/parallel/test-event-emitter-method-names.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'test/parallel/test-event-emitter-method-names.js') diff --git a/test/parallel/test-event-emitter-method-names.js b/test/parallel/test-event-emitter-method-names.js index c74b88aff7..684024d027 100644 --- a/test/parallel/test-event-emitter-method-names.js +++ b/test/parallel/test-event-emitter-method-names.js @@ -27,8 +27,9 @@ const events = require('events'); const E = events.EventEmitter.prototype; assert.strictEqual(E.constructor.name, 'EventEmitter'); assert.strictEqual(E.on, E.addListener); // Same method. +assert.strictEqual(E.off, E.removeListener); // Same method. Object.getOwnPropertyNames(E).forEach(function(name) { - if (name === 'constructor' || name === 'on') return; + if (name === 'constructor' || name === 'on' || name === 'off') return; if (typeof E[name] !== 'function') return; assert.strictEqual(E[name].name, name); }); -- cgit v1.2.3