diff options
| author | Anna Henningsen <anna@addaleax.net> | 2019-11-08 20:40:46 +0200 |
|---|---|---|
| committer | Daniel Bevenius <daniel.bevenius@gmail.com> | 2019-11-12 06:29:23 +0100 |
| commit | e66a2acc4cb9fc09fc32d1833b89ae56468a0931 (patch) | |
| tree | 2db9ffe469a2c662eda46cef848a17d39b8a3787 /src/node_zlib.cc | |
| parent | f8c069f5b88a25304ee2fc638c51464b4df196dd (diff) | |
| download | android-node-v8-e66a2acc4cb9fc09fc32d1833b89ae56468a0931.tar.gz android-node-v8-e66a2acc4cb9fc09fc32d1833b89ae56468a0931.tar.bz2 android-node-v8-e66a2acc4cb9fc09fc32d1833b89ae56468a0931.zip | |
src: migrate off ArrayBuffer::GetContents
V8 deprecates `GetContents()` in favour of `GetBackingStore()`.
Update our code to reflect that.
V8 also deprecates `Externalize()` and `IsExternal()`; we should
be able to remove all usage of this once V8 8.0 is there.
PR-URL: https://github.com/nodejs/node/pull/30339
Refs: https://github.com/v8/v8/commit/bfe3d6bce734e596e312465e207bcfd55a59fe34
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Diffstat (limited to 'src/node_zlib.cc')
| -rw-r--r-- | src/node_zlib.cc | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/src/node_zlib.cc b/src/node_zlib.cc index fdcf685caf..739e36d699 100644 --- a/src/node_zlib.cc +++ b/src/node_zlib.cc @@ -590,7 +590,8 @@ class ZlibStream : public CompressionStream<ZlibContext> { CHECK(args[4]->IsUint32Array()); Local<Uint32Array> array = args[4].As<Uint32Array>(); Local<ArrayBuffer> ab = array->Buffer(); - uint32_t* write_result = static_cast<uint32_t*>(ab->GetContents().Data()); + uint32_t* write_result = static_cast<uint32_t*>( + ab->GetBackingStore()->Data()); CHECK(args[5]->IsFunction()); Local<Function> write_js_callback = args[5].As<Function>(); |