From e66a2acc4cb9fc09fc32d1833b89ae56468a0931 Mon Sep 17 00:00:00 2001 From: Anna Henningsen Date: Fri, 8 Nov 2019 20:40:46 +0200 Subject: src: migrate off ArrayBuffer::GetContents MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit V8 deprecates `GetContents()` in favour of `GetBackingStore()`. Update our code to reflect that. V8 also deprecates `Externalize()` and `IsExternal()`; we should be able to remove all usage of this once V8 8.0 is there. PR-URL: https://github.com/nodejs/node/pull/30339 Refs: https://github.com/v8/v8/commit/bfe3d6bce734e596e312465e207bcfd55a59fe34 Reviewed-By: Gus Caplan Reviewed-By: Michaƫl Zasso Reviewed-By: Colin Ihrig Reviewed-By: Jiawen Geng Reviewed-By: David Carlier --- src/node_zlib.cc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'src/node_zlib.cc') diff --git a/src/node_zlib.cc b/src/node_zlib.cc index fdcf685caf..739e36d699 100644 --- a/src/node_zlib.cc +++ b/src/node_zlib.cc @@ -590,7 +590,8 @@ class ZlibStream : public CompressionStream { CHECK(args[4]->IsUint32Array()); Local array = args[4].As(); Local ab = array->Buffer(); - uint32_t* write_result = static_cast(ab->GetContents().Data()); + uint32_t* write_result = static_cast( + ab->GetBackingStore()->Data()); CHECK(args[5]->IsFunction()); Local write_js_callback = args[5].As(); -- cgit v1.2.3