summaryrefslogtreecommitdiff
path: root/src/node_util.cc
diff options
context:
space:
mode:
authorAnna Henningsen <anna@addaleax.net>2019-04-17 23:16:22 +0200
committerAnna Henningsen <anna@addaleax.net>2019-04-30 00:23:33 +0200
commit723d5c058fa180684df13bd2a83bbf3ca6201957 (patch)
tree6aeb4bc88e6c437853327cced05ab797827c22f2 /src/node_util.cc
parent095bd569aef4fec433ddb26e681eaabff1f7fd10 (diff)
downloadandroid-node-v8-723d5c058fa180684df13bd2a83bbf3ca6201957.tar.gz
android-node-v8-723d5c058fa180684df13bd2a83bbf3ca6201957.tar.bz2
android-node-v8-723d5c058fa180684df13bd2a83bbf3ca6201957.zip
src: prefer v8::Global over node::Persistent
`v8::Global` is essentially a nicer variant of `node::Persistent` that, in addition to reset-on-destroy, also implements move semantics. This commit makes the necessary replacements, removes `node::Persistent` and (now-)unnecessary inclusions of the `node_persistent.h` header, and makes some of the functions that take Persistents as arguments more generic so that they work with all `v8::PersistentBase` flavours. PR-URL: https://github.com/nodejs/node/pull/27287 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Diffstat (limited to 'src/node_util.cc')
-rw-r--r--src/node_util.cc3
1 files changed, 2 insertions, 1 deletions
diff --git a/src/node_util.cc b/src/node_util.cc
index 961df0b73c..180c58c416 100644
--- a/src/node_util.cc
+++ b/src/node_util.cc
@@ -13,6 +13,7 @@ using v8::Context;
using v8::Function;
using v8::FunctionCallbackInfo;
using v8::FunctionTemplate;
+using v8::Global;
using v8::IndexFilter;
using v8::Integer;
using v8::Isolate;
@@ -189,7 +190,7 @@ class WeakReference : public BaseObject {
SET_NO_MEMORY_INFO()
private:
- Persistent<Object> target_;
+ Global<Object> target_;
};
static void GuessHandleType(const FunctionCallbackInfo<Value>& args) {