diff options
author | Sam Roberts <vieuxtech@gmail.com> | 2019-04-09 15:21:36 -0700 |
---|---|---|
committer | Sam Roberts <vieuxtech@gmail.com> | 2019-04-12 12:33:37 -0700 |
commit | 060d901f87b3d87314f8540eb02f315e2952f581 (patch) | |
tree | 53159171201703bb6d8a4e780c8624a5c6c8cbb5 /src/node_util.cc | |
parent | 7b0d8673898e65a368108264c77bccaa3e004028 (diff) | |
download | android-node-v8-060d901f87b3d87314f8540eb02f315e2952f581.tar.gz android-node-v8-060d901f87b3d87314f8540eb02f315e2952f581.tar.bz2 android-node-v8-060d901f87b3d87314f8540eb02f315e2952f581.zip |
src: replace FromJust() with Check() when possible
FromJust() is often used not for its return value, but for its
side-effects. In these cases, Check() exists, and is more clear as to
the intent. From its comment:
To be used, where the actual value of the Maybe is not needed, like
Object::Set.
See: https://github.com/nodejs/node/pull/26929/files#r269256335
PR-URL: https://github.com/nodejs/node/pull/27162
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Michaƫl Zasso <targos@protonmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Diffstat (limited to 'src/node_util.cc')
-rw-r--r-- | src/node_util.cc | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/src/node_util.cc b/src/node_util.cc index b1cdc11a99..960e194f76 100644 --- a/src/node_util.cc +++ b/src/node_util.cc @@ -220,7 +220,7 @@ void Initialize(Local<Object> target, #define V(name, _) \ target->Set(context, \ FIXED_ONE_BYTE_STRING(env->isolate(), #name), \ - Integer::NewFromUnsigned(env->isolate(), index++)).FromJust(); + Integer::NewFromUnsigned(env->isolate(), index++)).Check(); { uint32_t index = 0; PER_ISOLATE_PRIVATE_SYMBOL_PROPERTIES(V) @@ -261,7 +261,7 @@ void Initialize(Local<Object> target, NODE_DEFINE_CONSTANT(constants, SKIP_SYMBOLS); target->Set(context, FIXED_ONE_BYTE_STRING(env->isolate(), "propertyFilter"), - constants).FromJust(); + constants).Check(); Local<String> should_abort_on_uncaught_toggle = FIXED_ONE_BYTE_STRING(env->isolate(), "shouldAbortOnUncaughtToggle"); @@ -279,7 +279,7 @@ void Initialize(Local<Object> target, weak_ref->SetClassName(weak_ref_string); env->SetProtoMethod(weak_ref, "get", WeakReference::Get); target->Set(context, weak_ref_string, - weak_ref->GetFunction(context).ToLocalChecked()).FromJust(); + weak_ref->GetFunction(context).ToLocalChecked()).Check(); } } // namespace util |