diff options
| author | Joyee Cheung <joyeec9h3@gmail.com> | 2019-03-06 15:25:18 +0100 |
|---|---|---|
| committer | Joyee Cheung <joyeec9h3@gmail.com> | 2019-03-11 23:30:27 +0800 |
| commit | ee2d2638ad468782ca3d30b5aa3b39ff281b80c1 (patch) | |
| tree | 5dc3e405dbd0275688a11606c34858fe57151575 /src/node_process_object.cc | |
| parent | 148254744134793cd6556c9749658f3872b03d00 (diff) | |
| download | android-node-v8-ee2d2638ad468782ca3d30b5aa3b39ff281b80c1.tar.gz android-node-v8-ee2d2638ad468782ca3d30b5aa3b39ff281b80c1.tar.bz2 android-node-v8-ee2d2638ad468782ca3d30b5aa3b39ff281b80c1.zip | |
process: delay creation of process.env after bootstrap/node.js
Make sure that no code is allowed to access process.env during
the execution of bootstrap/node.js.
PR-URL: https://github.com/nodejs/node/pull/26515
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Diffstat (limited to 'src/node_process_object.cc')
| -rw-r--r-- | src/node_process_object.cc | 12 |
1 files changed, 0 insertions, 12 deletions
diff --git a/src/node_process_object.cc b/src/node_process_object.cc index 3e0bac6d23..c8a2c26690 100644 --- a/src/node_process_object.cc +++ b/src/node_process_object.cc @@ -151,18 +151,6 @@ MaybeLocal<Object> CreateProcessObject( ToV8Value(env->context(), exec_args) .ToLocalChecked()).FromJust(); - Local<Object> env_var_proxy; - if (!CreateEnvVarProxy(context, isolate, env->as_callback_data()) - .ToLocal(&env_var_proxy)) - return MaybeLocal<Object>(); - - // process.env - process - ->Set(env->context(), - FIXED_ONE_BYTE_STRING(env->isolate(), "env"), - env_var_proxy) - .FromJust(); - READONLY_PROPERTY(process, "pid", Integer::New(env->isolate(), uv_os_getpid())); |