From ee2d2638ad468782ca3d30b5aa3b39ff281b80c1 Mon Sep 17 00:00:00 2001 From: Joyee Cheung Date: Wed, 6 Mar 2019 15:25:18 +0100 Subject: process: delay creation of process.env after bootstrap/node.js Make sure that no code is allowed to access process.env during the execution of bootstrap/node.js. PR-URL: https://github.com/nodejs/node/pull/26515 Reviewed-By: Anna Henningsen Reviewed-By: Ruben Bridgewater Reviewed-By: James M Snell --- src/node_process_object.cc | 12 ------------ 1 file changed, 12 deletions(-) (limited to 'src/node_process_object.cc') diff --git a/src/node_process_object.cc b/src/node_process_object.cc index 3e0bac6d23..c8a2c26690 100644 --- a/src/node_process_object.cc +++ b/src/node_process_object.cc @@ -151,18 +151,6 @@ MaybeLocal CreateProcessObject( ToV8Value(env->context(), exec_args) .ToLocalChecked()).FromJust(); - Local env_var_proxy; - if (!CreateEnvVarProxy(context, isolate, env->as_callback_data()) - .ToLocal(&env_var_proxy)) - return MaybeLocal(); - - // process.env - process - ->Set(env->context(), - FIXED_ONE_BYTE_STRING(env->isolate(), "env"), - env_var_proxy) - .FromJust(); - READONLY_PROPERTY(process, "pid", Integer::New(env->isolate(), uv_os_getpid())); -- cgit v1.2.3