diff options
| author | Joyee Cheung <joyeec9h3@gmail.com> | 2019-03-23 07:39:52 +0800 |
|---|---|---|
| committer | Joyee Cheung <joyeec9h3@gmail.com> | 2019-04-06 12:01:45 +0800 |
| commit | 864860e9f3d4eed0b0b81af55197d7e525ea6306 (patch) | |
| tree | ed0c9cbc1cea99323cd4fa4c5385a11b262be8ee /src/node_process_methods.cc | |
| parent | baa54a5ae78ff04a3e8d8ac97c052304a6f6c18c (diff) | |
| download | android-node-v8-864860e9f3d4eed0b0b81af55197d7e525ea6306.tar.gz android-node-v8-864860e9f3d4eed0b0b81af55197d7e525ea6306.tar.bz2 android-node-v8-864860e9f3d4eed0b0b81af55197d7e525ea6306.zip | |
src: port coverage serialization to C++
This patch moves the serialization of coverage profiles into
C++. With this we no longer need to patch `process.reallyExit`
and hook into the exit events, but instead hook into relevant
places in C++ which are safe from user manipulation. This also
makes the code easier to reuse for other types of profiles.
PR-URL: https://github.com/nodejs/node/pull/26874
Reviewed-By: Ben Coe <bencoe@gmail.com>
Diffstat (limited to 'src/node_process_methods.cc')
| -rw-r--r-- | src/node_process_methods.cc | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/src/node_process_methods.cc b/src/node_process_methods.cc index dd27329ee2..e53a5a7015 100644 --- a/src/node_process_methods.cc +++ b/src/node_process_methods.cc @@ -171,6 +171,12 @@ static void Kill(const FunctionCallbackInfo<Value>& args) { if (!args[0]->Int32Value(context).To(&pid)) return; int sig; if (!args[1]->Int32Value(context).To(&sig)) return; + // TODO(joyeecheung): white list the signals? + +#if HAVE_INSPECTOR + profiler::EndStartedProfilers(env); +#endif + int err = uv_kill(pid, sig); args.GetReturnValue().Set(err); } |