From 864860e9f3d4eed0b0b81af55197d7e525ea6306 Mon Sep 17 00:00:00 2001 From: Joyee Cheung Date: Sat, 23 Mar 2019 07:39:52 +0800 Subject: src: port coverage serialization to C++ This patch moves the serialization of coverage profiles into C++. With this we no longer need to patch `process.reallyExit` and hook into the exit events, but instead hook into relevant places in C++ which are safe from user manipulation. This also makes the code easier to reuse for other types of profiles. PR-URL: https://github.com/nodejs/node/pull/26874 Reviewed-By: Ben Coe --- src/node_process_methods.cc | 6 ++++++ 1 file changed, 6 insertions(+) (limited to 'src/node_process_methods.cc') diff --git a/src/node_process_methods.cc b/src/node_process_methods.cc index dd27329ee2..e53a5a7015 100644 --- a/src/node_process_methods.cc +++ b/src/node_process_methods.cc @@ -171,6 +171,12 @@ static void Kill(const FunctionCallbackInfo& args) { if (!args[0]->Int32Value(context).To(&pid)) return; int sig; if (!args[1]->Int32Value(context).To(&sig)) return; + // TODO(joyeecheung): white list the signals? + +#if HAVE_INSPECTOR + profiler::EndStartedProfilers(env); +#endif + int err = uv_kill(pid, sig); args.GetReturnValue().Set(err); } -- cgit v1.2.3