diff options
| author | cjihrig <cjihrig@gmail.com> | 2019-03-03 12:05:38 -0500 |
|---|---|---|
| committer | cjihrig <cjihrig@gmail.com> | 2019-03-05 15:35:58 -0500 |
| commit | 30ee27784c935dd174238edecbd93edb4aab8972 (patch) | |
| tree | 3f098f45a3d7e226268f45b64954657221bcb8ff /src/node_options.cc | |
| parent | c78788a0219cc950be7159e65b9e8db01e9c1a7a (diff) | |
| download | android-node-v8-30ee27784c935dd174238edecbd93edb4aab8972.tar.gz android-node-v8-30ee27784c935dd174238edecbd93edb4aab8972.tar.bz2 android-node-v8-30ee27784c935dd174238edecbd93edb4aab8972.zip | |
report: refactor configuration management
This commit removes process.report.setOptions(). Instead of
using complex configuration synchronization between C++ and
JS, this commit introduces individual getters and setters.
PR-URL: https://github.com/nodejs/node/pull/26414
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Wyatt Preul <wpreul@gmail.com>
Diffstat (limited to 'src/node_options.cc')
| -rw-r--r-- | src/node_options.cc | 8 |
1 files changed, 7 insertions, 1 deletions
diff --git a/src/node_options.cc b/src/node_options.cc index 7107549bd4..f2961b2147 100644 --- a/src/node_options.cc +++ b/src/node_options.cc @@ -57,8 +57,14 @@ void PerProcessOptions::CheckOptions(std::vector<std::string>* errors) { void PerIsolateOptions::CheckOptions(std::vector<std::string>* errors) { per_env->CheckOptions(errors); #ifdef NODE_REPORT - if (per_env->experimental_report) + if (per_env->experimental_report) { + // Assign the report_signal default value here. Once the + // --experimental-report flag is dropped, move this initialization to + // node_options.h, where report_signal is declared. + if (report_signal.empty()) + report_signal = "SIGUSR2"; return; + } if (!report_directory.empty()) { errors->push_back("--diagnostic-report-directory option is valid only when " |