From 30ee27784c935dd174238edecbd93edb4aab8972 Mon Sep 17 00:00:00 2001 From: cjihrig Date: Sun, 3 Mar 2019 12:05:38 -0500 Subject: report: refactor configuration management This commit removes process.report.setOptions(). Instead of using complex configuration synchronization between C++ and JS, this commit introduces individual getters and setters. PR-URL: https://github.com/nodejs/node/pull/26414 Reviewed-By: Richard Lau Reviewed-By: Wyatt Preul --- src/node_options.cc | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) (limited to 'src/node_options.cc') diff --git a/src/node_options.cc b/src/node_options.cc index 7107549bd4..f2961b2147 100644 --- a/src/node_options.cc +++ b/src/node_options.cc @@ -57,8 +57,14 @@ void PerProcessOptions::CheckOptions(std::vector* errors) { void PerIsolateOptions::CheckOptions(std::vector* errors) { per_env->CheckOptions(errors); #ifdef NODE_REPORT - if (per_env->experimental_report) + if (per_env->experimental_report) { + // Assign the report_signal default value here. Once the + // --experimental-report flag is dropped, move this initialization to + // node_options.h, where report_signal is declared. + if (report_signal.empty()) + report_signal = "SIGUSR2"; return; + } if (!report_directory.empty()) { errors->push_back("--diagnostic-report-directory option is valid only when " -- cgit v1.2.3