summaryrefslogtreecommitdiff
path: root/src/node_main_instance.cc
diff options
context:
space:
mode:
authorGauthamBanasandra <gautham.bangalore@gmail.com>2019-07-06 19:24:26 +0530
committerRich Trott <rtrott@gmail.com>2019-07-12 21:59:36 -0700
commitcf929c04b082f0d1d980772d343f056ea4fd7359 (patch)
tree974445741cfeb0fec793bf4694841f5428985914 /src/node_main_instance.cc
parent9c4bdfe9b27aae59ca5a9c9e9e9bf0460d284571 (diff)
downloadandroid-node-v8-cf929c04b082f0d1d980772d343f056ea4fd7359.tar.gz
android-node-v8-cf929c04b082f0d1d980772d343f056ea4fd7359.tar.bz2
android-node-v8-cf929c04b082f0d1d980772d343f056ea4fd7359.zip
src, tools: replace raw ptr with smart ptr
NodeMainInstance::Create will now returrn an instance of NodeMainInstance in a unique_ptr. PR-URL: https://github.com/nodejs/node/pull/28577 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Diffstat (limited to 'src/node_main_instance.cc')
-rw-r--r--src/node_main_instance.cc6
1 files changed, 3 insertions, 3 deletions
diff --git a/src/node_main_instance.cc b/src/node_main_instance.cc
index f49b9fbb4d..5d5a48cc36 100644
--- a/src/node_main_instance.cc
+++ b/src/node_main_instance.cc
@@ -30,13 +30,14 @@ NodeMainInstance::NodeMainInstance(Isolate* isolate,
SetIsolateUpForNode(isolate_, IsolateSettingCategories::kMisc);
}
-NodeMainInstance* NodeMainInstance::Create(
+std::unique_ptr<NodeMainInstance> NodeMainInstance::Create(
Isolate* isolate,
uv_loop_t* event_loop,
MultiIsolatePlatform* platform,
const std::vector<std::string>& args,
const std::vector<std::string>& exec_args) {
- return new NodeMainInstance(isolate, event_loop, platform, args, exec_args);
+ return std::unique_ptr<NodeMainInstance>(
+ new NodeMainInstance(isolate, event_loop, platform, args, exec_args));
}
NodeMainInstance::NodeMainInstance(
@@ -81,7 +82,6 @@ NodeMainInstance::NodeMainInstance(
void NodeMainInstance::Dispose() {
CHECK(!owns_isolate_);
platform_->DrainTasks(isolate_);
- delete this;
}
NodeMainInstance::~NodeMainInstance() {