From cf929c04b082f0d1d980772d343f056ea4fd7359 Mon Sep 17 00:00:00 2001
From: GauthamBanasandra <gautham.bangalore@gmail.com>
Date: Sat, 6 Jul 2019 19:24:26 +0530
Subject: src, tools: replace raw ptr with smart ptr

NodeMainInstance::Create will now returrn
an instance of NodeMainInstance in a
unique_ptr.

PR-URL: https://github.com/nodejs/node/pull/28577
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
---
 src/node_main_instance.cc | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

(limited to 'src/node_main_instance.cc')

diff --git a/src/node_main_instance.cc b/src/node_main_instance.cc
index f49b9fbb4d..5d5a48cc36 100644
--- a/src/node_main_instance.cc
+++ b/src/node_main_instance.cc
@@ -30,13 +30,14 @@ NodeMainInstance::NodeMainInstance(Isolate* isolate,
   SetIsolateUpForNode(isolate_, IsolateSettingCategories::kMisc);
 }
 
-NodeMainInstance* NodeMainInstance::Create(
+std::unique_ptr<NodeMainInstance> NodeMainInstance::Create(
     Isolate* isolate,
     uv_loop_t* event_loop,
     MultiIsolatePlatform* platform,
     const std::vector<std::string>& args,
     const std::vector<std::string>& exec_args) {
-  return new NodeMainInstance(isolate, event_loop, platform, args, exec_args);
+  return std::unique_ptr<NodeMainInstance>(
+      new NodeMainInstance(isolate, event_loop, platform, args, exec_args));
 }
 
 NodeMainInstance::NodeMainInstance(
@@ -81,7 +82,6 @@ NodeMainInstance::NodeMainInstance(
 void NodeMainInstance::Dispose() {
   CHECK(!owns_isolate_);
   platform_->DrainTasks(isolate_);
-  delete this;
 }
 
 NodeMainInstance::~NodeMainInstance() {
-- 
cgit v1.2.3