diff options
author | Ben Noordhuis <info@bnoordhuis.nl> | 2017-12-13 14:51:33 +0100 |
---|---|---|
committer | Daniel Bevenius <daniel.bevenius@gmail.com> | 2017-12-15 07:47:42 +0100 |
commit | 98a6f63e457859be44bb76a051fc17ccf296edbf (patch) | |
tree | 6b9306b73b00f975b0f30a33ef18c0d8a4989432 /src/node_crypto.h | |
parent | e989cd1faf32f0123d176a54b153219cc10e3bc7 (diff) | |
download | android-node-v8-98a6f63e457859be44bb76a051fc17ccf296edbf.tar.gz android-node-v8-98a6f63e457859be44bb76a051fc17ccf296edbf.tar.bz2 android-node-v8-98a6f63e457859be44bb76a051fc17ccf296edbf.zip |
src: fix -Wundefined-inline warnings
Fix compiler warnings introduced in commit 47edfd9c3c ("crypto: move
node_crypto_clienthello-inl.h to cc") by moving constructors around.
They were defined inline but depended on definitions
from `node_crypto_clienthello-inl.h`.
PR-URL: https://github.com/nodejs/node/pull/17649
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Diffstat (limited to 'src/node_crypto.h')
-rw-r--r-- | src/node_crypto.h | 14 |
1 files changed, 1 insertions, 13 deletions
diff --git a/src/node_crypto.h b/src/node_crypto.h index 636cbb99d4..463be5f072 100644 --- a/src/node_crypto.h +++ b/src/node_crypto.h @@ -432,19 +432,7 @@ class Connection : public AsyncWrap, public SSLWrap<Connection> { Connection(Environment* env, v8::Local<v8::Object> wrap, SecureContext* sc, - SSLWrap<Connection>::Kind kind) - : AsyncWrap(env, wrap, AsyncWrap::PROVIDER_SSLCONNECTION), - SSLWrap<Connection>(env, sc, kind), - bio_read_(nullptr), - bio_write_(nullptr), - hello_offset_(0) { - MakeWeak<Connection>(this); - Wrap(wrap, this); - hello_parser_.Start(SSLWrap<Connection>::OnClientHello, - OnClientHelloParseEnd, - this); - enable_session_callbacks(); - } + SSLWrap<Connection>::Kind kind); private: static void SSLInfoCallback(const SSL *ssl, int where, int ret); |