diff options
| author | Anna Henningsen <anna@addaleax.net> | 2019-04-17 23:16:22 +0200 |
|---|---|---|
| committer | Anna Henningsen <anna@addaleax.net> | 2019-04-30 00:23:33 +0200 |
| commit | 723d5c058fa180684df13bd2a83bbf3ca6201957 (patch) | |
| tree | 6aeb4bc88e6c437853327cced05ab797827c22f2 /src/node_crypto.h | |
| parent | 095bd569aef4fec433ddb26e681eaabff1f7fd10 (diff) | |
| download | android-node-v8-723d5c058fa180684df13bd2a83bbf3ca6201957.tar.gz android-node-v8-723d5c058fa180684df13bd2a83bbf3ca6201957.tar.bz2 android-node-v8-723d5c058fa180684df13bd2a83bbf3ca6201957.zip | |
src: prefer v8::Global over node::Persistent
`v8::Global` is essentially a nicer variant of `node::Persistent` that,
in addition to reset-on-destroy, also implements move semantics.
This commit makes the necessary replacements, removes
`node::Persistent` and (now-)unnecessary inclusions of the
`node_persistent.h` header, and makes some of the functions that
take Persistents as arguments more generic so that they work with all
`v8::PersistentBase` flavours.
PR-URL: https://github.com/nodejs/node/pull/27287
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Diffstat (limited to 'src/node_crypto.h')
| -rw-r--r-- | src/node_crypto.h | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/node_crypto.h b/src/node_crypto.h index 657789afc4..44206b58dd 100644 --- a/src/node_crypto.h +++ b/src/node_crypto.h @@ -321,8 +321,8 @@ class SSLWrap { ClientHelloParser hello_parser_; - Persistent<v8::ArrayBufferView> ocsp_response_; - Persistent<v8::Value> sni_context_; + v8::Global<v8::ArrayBufferView> ocsp_response_; + v8::Global<v8::Value> sni_context_; friend class SecureContext; }; |