diff options
| author | Daniel Bevenius <daniel.bevenius@gmail.com> | 2017-05-24 14:37:29 +0200 |
|---|---|---|
| committer | Daniel Bevenius <daniel.bevenius@gmail.com> | 2017-05-26 06:01:46 +0200 |
| commit | 49e91e2649d9a27b46243e2fe6c23d96f9fcdc83 (patch) | |
| tree | 52ffae76fa26d7c599bfa3353ad1ae3d46e9dcca /src/node_crypto.h | |
| parent | ab28e0a86a82eb3f7363b980fcb91261d7e7a2a0 (diff) | |
| download | android-node-v8-49e91e2649d9a27b46243e2fe6c23d96f9fcdc83.tar.gz android-node-v8-49e91e2649d9a27b46243e2fe6c23d96f9fcdc83.tar.bz2 android-node-v8-49e91e2649d9a27b46243e2fe6c23d96f9fcdc83.zip | |
crypto: remove root_cert_store from node_crypto.h
root_cert_store is defined as extern in node_crypto.h but only used in
node_crypto.cc. It is then set using SSL_CTX_set_cert_store. The only
usages of SSL_CTX_get_cert_store are in node_crypto.cc which would all
be accessing the same X509_STORE through the root_cert_store pointer as
far as I can tell. Am I missing something here?
This commit suggests removing it from the header and making it static
in node_crypto.cc.
PR-URL: https://github.com/nodejs/node/pull/13194
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Diffstat (limited to 'src/node_crypto.h')
| -rw-r--r-- | src/node_crypto.h | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/src/node_crypto.h b/src/node_crypto.h index 2d78a38974..33c9cf783e 100644 --- a/src/node_crypto.h +++ b/src/node_crypto.h @@ -84,8 +84,6 @@ enum CheckResult { extern int VerifyCallback(int preverify_ok, X509_STORE_CTX* ctx); -extern X509_STORE* root_cert_store; - extern void UseExtraCaCerts(const std::string& file); class SecureContext : public BaseObject { |