diff options
| author | Michael Ruddy <mruddybtc@gmail.com> | 2015-11-19 14:00:00 -0500 |
|---|---|---|
| committer | Ben Noordhuis <info@bnoordhuis.nl> | 2015-12-07 12:44:46 +0100 |
| commit | 322b36c0a163bc723a6d612d740f98775e0750f6 (patch) | |
| tree | b2d7487fff1dacc3f06dc19ebdcd3f7747a42851 /src/node_crypto.h | |
| parent | 19e06d71cfa26b6f8a1ce0fa566891553eb351b2 (diff) | |
| download | android-node-v8-322b36c0a163bc723a6d612d740f98775e0750f6.tar.gz android-node-v8-322b36c0a163bc723a6d612d740f98775e0750f6.tar.bz2 android-node-v8-322b36c0a163bc723a6d612d740f98775e0750f6.zip | |
crypto: simplify using pre-existing keys with ECDH
These changes simplify using ECDH with private keys that are not
dynamically generated with ECDH.generateKeys.
Support for computing the public key corresponding to the given private
key was added. Validity checks to reduce the possibility of computing
a weak or invalid shared secret were also added.
Finally, ECDH.setPublicKey was softly deprecated.
PR-URL: https://github.com/nodejs/node/pull/3511
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Shigeki Ohtsu <ohtsu@iij.ad.jp>
Diffstat (limited to 'src/node_crypto.h')
| -rw-r--r-- | src/node_crypto.h | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/src/node_crypto.h b/src/node_crypto.h index beeb2fb445..d3d66e32dd 100644 --- a/src/node_crypto.h +++ b/src/node_crypto.h @@ -693,7 +693,6 @@ class ECDH : public BaseObject { protected: ECDH(Environment* env, v8::Local<v8::Object> wrap, EC_KEY* key) : BaseObject(env, wrap), - generated_(false), key_(key), group_(EC_KEY_get0_group(key_)) { MakeWeak<ECDH>(this); @@ -710,7 +709,9 @@ class ECDH : public BaseObject { EC_POINT* BufferToPoint(char* data, size_t len); - bool generated_; + bool IsKeyPairValid(); + bool IsKeyValidForCurve(const BIGNUM* private_key); + EC_KEY* key_; const EC_GROUP* group_; }; |