summaryrefslogtreecommitdiff
path: root/src/node.cc
diff options
context:
space:
mode:
authorAnna Henningsen <anna@addaleax.net>2019-01-27 14:21:21 +0100
committerAnna Henningsen <anna@addaleax.net>2019-01-29 20:02:01 +0100
commit95571ac1e9acd09d0b06b2315aabb0cc4e158572 (patch)
tree67922f8c1b831d7fce0b083a3fa2d5bdd8664f51 /src/node.cc
parent4dbff090c3ff2ba43b0fbb06cc65bef5b5d81008 (diff)
downloadandroid-node-v8-95571ac1e9acd09d0b06b2315aabb0cc4e158572.tar.gz
android-node-v8-95571ac1e9acd09d0b06b2315aabb0cc4e158572.tar.bz2
android-node-v8-95571ac1e9acd09d0b06b2315aabb0cc4e158572.zip
src: pass along errors from process obj instantiation
PR-URL: https://github.com/nodejs/node/pull/25734 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gus Caplan <me@gus.host>
Diffstat (limited to 'src/node.cc')
-rw-r--r--src/node.cc6
1 files changed, 4 insertions, 2 deletions
diff --git a/src/node.cc b/src/node.cc
index 5b5cff078b..881ace6e42 100644
--- a/src/node.cc
+++ b/src/node.cc
@@ -1179,7 +1179,8 @@ Environment* CreateEnvironment(IsolateData* isolate_data,
std::vector<std::string> args(argv, argv + argc);
std::vector<std::string> exec_args(exec_argv, exec_argv + exec_argc);
Environment* env = new Environment(isolate_data, context);
- env->Start(args, exec_args, per_process::v8_is_profiling);
+ env->Start(per_process::v8_is_profiling);
+ env->CreateProcessObject(args, exec_args);
return env;
}
@@ -1253,7 +1254,8 @@ inline int Start(Isolate* isolate, IsolateData* isolate_data,
Local<Context> context = NewContext(isolate);
Context::Scope context_scope(context);
Environment env(isolate_data, context);
- env.Start(args, exec_args, per_process::v8_is_profiling);
+ env.Start(per_process::v8_is_profiling);
+ env.CreateProcessObject(args, exec_args);
#if HAVE_INSPECTOR && NODE_USE_V8_PLATFORM
CHECK(!env.inspector_agent()->IsListening());