From 95571ac1e9acd09d0b06b2315aabb0cc4e158572 Mon Sep 17 00:00:00 2001 From: Anna Henningsen Date: Sun, 27 Jan 2019 14:21:21 +0100 Subject: src: pass along errors from process obj instantiation PR-URL: https://github.com/nodejs/node/pull/25734 Reviewed-By: James M Snell Reviewed-By: Gus Caplan --- src/node.cc | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) (limited to 'src/node.cc') diff --git a/src/node.cc b/src/node.cc index 5b5cff078b..881ace6e42 100644 --- a/src/node.cc +++ b/src/node.cc @@ -1179,7 +1179,8 @@ Environment* CreateEnvironment(IsolateData* isolate_data, std::vector args(argv, argv + argc); std::vector exec_args(exec_argv, exec_argv + exec_argc); Environment* env = new Environment(isolate_data, context); - env->Start(args, exec_args, per_process::v8_is_profiling); + env->Start(per_process::v8_is_profiling); + env->CreateProcessObject(args, exec_args); return env; } @@ -1253,7 +1254,8 @@ inline int Start(Isolate* isolate, IsolateData* isolate_data, Local context = NewContext(isolate); Context::Scope context_scope(context); Environment env(isolate_data, context); - env.Start(args, exec_args, per_process::v8_is_profiling); + env.Start(per_process::v8_is_profiling); + env.CreateProcessObject(args, exec_args); #if HAVE_INSPECTOR && NODE_USE_V8_PLATFORM CHECK(!env.inspector_agent()->IsListening()); -- cgit v1.2.3