summaryrefslogtreecommitdiff
path: root/src/large_pages
diff options
context:
space:
mode:
authorAnna Henningsen <anna@addaleax.net>2019-10-26 18:29:46 +0200
committerAnna Henningsen <anna@addaleax.net>2019-11-07 10:39:40 +0100
commit6072e01c938e22498cd46c3d8a2c21a16a632456 (patch)
tree4d0925f227eba3f382b246ea2ff878b64eb47952 /src/large_pages
parent35ae49db515ec4a7ad74ee3666eda34e7bfd85b5 (diff)
downloadandroid-node-v8-6072e01c938e22498cd46c3d8a2c21a16a632456.tar.gz
android-node-v8-6072e01c938e22498cd46c3d8a2c21a16a632456.tar.bz2
android-node-v8-6072e01c938e22498cd46c3d8a2c21a16a632456.zip
src: do not use `std::function` for `OnScopeLeave`
Using `std::function` adds an extra layer of indirection, and in particular, heap allocations that are not necessary in our use case here. PR-URL: https://github.com/nodejs/node/pull/30134 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Diffstat (limited to 'src/large_pages')
-rw-r--r--src/large_pages/node_large_page.cc2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/large_pages/node_large_page.cc b/src/large_pages/node_large_page.cc
index 4e2f8fc441..68fa178b40 100644
--- a/src/large_pages/node_large_page.cc
+++ b/src/large_pages/node_large_page.cc
@@ -333,7 +333,7 @@ MoveTextRegionToLargePages(const text_region& r) {
PrintSystemError(errno);
return -1;
}
- OnScopeLeave munmap_on_return([nmem, size]() {
+ auto munmap_on_return = OnScopeLeave([nmem, size]() {
if (-1 == munmap(nmem, size)) PrintSystemError(errno);
});