From 6072e01c938e22498cd46c3d8a2c21a16a632456 Mon Sep 17 00:00:00 2001 From: Anna Henningsen Date: Sat, 26 Oct 2019 18:29:46 +0200 Subject: src: do not use `std::function` for `OnScopeLeave` Using `std::function` adds an extra layer of indirection, and in particular, heap allocations that are not necessary in our use case here. PR-URL: https://github.com/nodejs/node/pull/30134 Reviewed-By: Gus Caplan Reviewed-By: Colin Ihrig Reviewed-By: David Carlier Reviewed-By: Franziska Hinkelmann Reviewed-By: James M Snell --- src/large_pages/node_large_page.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src/large_pages') diff --git a/src/large_pages/node_large_page.cc b/src/large_pages/node_large_page.cc index 4e2f8fc441..68fa178b40 100644 --- a/src/large_pages/node_large_page.cc +++ b/src/large_pages/node_large_page.cc @@ -333,7 +333,7 @@ MoveTextRegionToLargePages(const text_region& r) { PrintSystemError(errno); return -1; } - OnScopeLeave munmap_on_return([nmem, size]() { + auto munmap_on_return = OnScopeLeave([nmem, size]() { if (-1 == munmap(nmem, size)) PrintSystemError(errno); }); -- cgit v1.2.3