diff options
| author | Trevor Norris <trev.norris@gmail.com> | 2014-12-09 05:24:59 +0100 |
|---|---|---|
| committer | Bert Belder <bertbelder@gmail.com> | 2014-12-09 17:57:14 +0100 |
| commit | a1da024cab797fd9318e7b754512887a71b1b242 (patch) | |
| tree | 27eb38774de37c4a5f62252b2f8fef6e7bd49591 /src/async-wrap.h | |
| parent | 5d17b16ecceb61c2c9946d8f59093561a8912142 (diff) | |
| download | android-node-v8-a1da024cab797fd9318e7b754512887a71b1b242.tar.gz android-node-v8-a1da024cab797fd9318e7b754512887a71b1b242.tar.bz2 android-node-v8-a1da024cab797fd9318e7b754512887a71b1b242.zip | |
node, async-wrap: remove MakeDomainCallback
C++ won't deoptimize like JS if specific conditional branches are
sporadically met in the future. Combined with the amount of code
duplication removal and simplified maintenance complexity, it makes more
sense to merge MakeCallback and MakeDomainCallback.
Additionally, type casting in V8 before verifying what that type is will
cause V8 to abort in debug mode if that type isn't what was expected.
Fix this by first checking the v8::Value before casting.
PR-URL: https://github.com/joyent/node/pull/8110
Signed-off-by: Trevor Norris <trev.norris@gmail.com>
Reviewed-by: Fedor Indutny <fedor@indutny.com>
Reviewed-by: Alexis Campailla <alexis@janeasystems.com>
Reviewed-by: Julien Gilli <julien.gilli@joyent.com>
Diffstat (limited to 'src/async-wrap.h')
| -rw-r--r-- | src/async-wrap.h | 7 |
1 files changed, 0 insertions, 7 deletions
diff --git a/src/async-wrap.h b/src/async-wrap.h index 9393c4c345..30e49946e7 100644 --- a/src/async-wrap.h +++ b/src/async-wrap.h @@ -74,13 +74,6 @@ class AsyncWrap : public BaseObject { private: inline AsyncWrap(); - // TODO(trevnorris): BURN IN FIRE! Remove this as soon as a suitable - // replacement is committed. - v8::Handle<v8::Value> MakeDomainCallback( - const v8::Handle<v8::Function> cb, - int argc, - v8::Handle<v8::Value>* argv); - uint32_t provider_type_; }; |