diff options
| author | Trevor Norris <trev.norris@gmail.com> | 2014-12-09 04:55:48 +0100 |
|---|---|---|
| committer | Bert Belder <bertbelder@gmail.com> | 2014-12-09 17:57:13 +0100 |
| commit | 5d17b16ecceb61c2c9946d8f59093561a8912142 (patch) | |
| tree | 78d0793bf52c22b230dd2a23e099bb55d9ad17dd /src/async-wrap.h | |
| parent | 0d60ab3efedd8b2fca607cc5ede7f866be412a0e (diff) | |
| download | android-node-v8-5d17b16ecceb61c2c9946d8f59093561a8912142.tar.gz android-node-v8-5d17b16ecceb61c2c9946d8f59093561a8912142.tar.bz2 android-node-v8-5d17b16ecceb61c2c9946d8f59093561a8912142.zip | |
async-wrap: move MakeCallback to .cc
MakeCallback is too large a function to be inlined. Likewise, only
having header files will not allow for any part of AsyncWrap to be
exposed cleanly via NODE_MODULE_CONTEXT_AWARE_BUILTIN().
PR-URL: https://github.com/joyent/node/pull/8110
Signed-off-by: Trevor Norris <trev.norris@gmail.com>
Reviewed-by: Fedor Indutny <fedor@indutny.com>
Reviewed-by: Alexis Campailla <alexis@janeasystems.com>
Reviewed-by: Julien Gilli <julien.gilli@joyent.com>
Diffstat (limited to 'src/async-wrap.h')
| -rw-r--r-- | src/async-wrap.h | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/src/async-wrap.h b/src/async-wrap.h index bac927fc81..9393c4c345 100644 --- a/src/async-wrap.h +++ b/src/async-wrap.h @@ -61,9 +61,9 @@ class AsyncWrap : public BaseObject { inline uint32_t provider_type() const; // Only call these within a valid HandleScope. - inline v8::Handle<v8::Value> MakeCallback(const v8::Handle<v8::Function> cb, - int argc, - v8::Handle<v8::Value>* argv); + v8::Handle<v8::Value> MakeCallback(const v8::Handle<v8::Function> cb, + int argc, + v8::Handle<v8::Value>* argv); inline v8::Handle<v8::Value> MakeCallback(const v8::Handle<v8::String> symbol, int argc, v8::Handle<v8::Value>* argv); @@ -76,7 +76,7 @@ class AsyncWrap : public BaseObject { // TODO(trevnorris): BURN IN FIRE! Remove this as soon as a suitable // replacement is committed. - inline v8::Handle<v8::Value> MakeDomainCallback( + v8::Handle<v8::Value> MakeDomainCallback( const v8::Handle<v8::Function> cb, int argc, v8::Handle<v8::Value>* argv); |