summaryrefslogtreecommitdiff
path: root/lib
diff options
context:
space:
mode:
authorRich Trott <rtrott@gmail.com>2018-07-06 09:48:59 -0700
committerRich Trott <rtrott@gmail.com>2018-07-10 13:44:47 -0700
commit11931ae71f8644a55c87fdf0149b1a250b21d4ee (patch)
tree681008a3ae748adf555ea9f2747706070ed79360 /lib
parentf54958ef2f6f66213f300f4fd2322e8d8c802e28 (diff)
downloadandroid-node-v8-11931ae71f8644a55c87fdf0149b1a250b21d4ee.tar.gz
android-node-v8-11931ae71f8644a55c87fdf0149b1a250b21d4ee.tar.bz2
android-node-v8-11931ae71f8644a55c87fdf0149b1a250b21d4ee.zip
http2: order declarations in core.js
Order declarations: * public modules in alphabetical order * internal modules in alphabetical order * process.binding() calls in alphabetical order * exports in alphabetical order PR-URL: https://github.com/nodejs/node/pull/21689 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Diffstat (limited to 'lib')
-rw-r--r--lib/internal/http2/core.js87
1 files changed, 45 insertions, 42 deletions
diff --git a/lib/internal/http2/core.js b/lib/internal/http2/core.js
index 3ef01c836d..5a4fa63335 100644
--- a/lib/internal/http2/core.js
+++ b/lib/internal/http2/core.js
@@ -2,22 +2,31 @@
/* eslint-disable no-use-before-define */
-const internalUtil = require('internal/util');
-internalUtil.assertCrypto();
+const {
+ assertCrypto,
+ customInspectSymbol: kInspect,
+ promisify
+} = require('internal/util');
+
+assertCrypto();
-const { internalBinding } = require('internal/bootstrap/loaders');
-const { async_id_symbol } = require('internal/async_hooks').symbols;
-const { UV_EOF } = process.binding('uv');
-const http = require('http');
-const binding = process.binding('http2');
-const { FileHandle } = process.binding('fs');
-const { StreamPipe } = internalBinding('stream_pipe');
const assert = require('assert');
const EventEmitter = require('events');
+const fs = require('fs');
+const http = require('http');
const net = require('net');
+const { Duplex } = require('stream');
const tls = require('tls');
+const { URL } = require('url');
const util = require('util');
-const fs = require('fs');
+
+const { kIncomingMessage } = require('_http_common');
+const { kServerResponse } = require('_http_server');
+const { StreamWrap } = require('_stream_wrap');
+
+const { defaultTriggerAsyncIdScope } = require('internal/async_hooks');
+const { async_id_symbol } = require('internal/async_hooks').symbols;
+const { internalBinding } = require('internal/bootstrap/loaders');
const {
codes: {
ERR_HTTP2_ALTSVC_INVALID_ORIGIN,
@@ -61,30 +70,11 @@ const {
ERR_SOCKET_CLOSED
}
} = require('internal/errors');
-const { StreamWrap } = require('_stream_wrap');
-const { Duplex } = require('stream');
-const { URL } = require('url');
+const { utcDate } = require('internal/http');
const { onServerStream,
Http2ServerRequest,
Http2ServerResponse,
} = require('internal/http2/compat');
-const { utcDate } = require('internal/http');
-const {
- promisify,
- customInspectSymbol: kInspect
-} = internalUtil;
-const { isArrayBufferView } = require('internal/util/types');
-const { defaultTriggerAsyncIdScope } = require('internal/async_hooks');
-const { _connectionListener: httpConnectionListener } = http;
-const { createPromise, promiseResolve } = process.binding('util');
-const debug = util.debuglog('http2');
-
-const kMaxFrameSize = (2 ** 24) - 1;
-const kMaxInt = (2 ** 32) - 1;
-const kMaxStreams = (2 ** 31) - 1;
-
-// eslint-disable-next-line no-control-regex
-const kQuotedString = /^[\x09\x20-\x5b\x5d-\x7e\x80-\xff]*$/;
const {
assertIsObject,
@@ -104,27 +94,40 @@ const {
updateOptionsBuffer,
updateSettingsBuffer
} = require('internal/http2/util');
-
-const {
- kTimeout,
- setUnrefTimeout,
- validateTimerDuration
-} = require('internal/timers');
const {
createWriteWrap,
writeGeneric,
writevGeneric
} = require('internal/stream_base_commons');
+const {
+ kTimeout,
+ setUnrefTimeout,
+ validateTimerDuration
+} = require('internal/timers');
+const { isArrayBufferView } = require('internal/util/types');
+const { FileHandle } = process.binding('fs');
+const binding = process.binding('http2');
const { ShutdownWrap } = process.binding('stream_wrap');
+const { createPromise, promiseResolve } = process.binding('util');
+const { UV_EOF } = process.binding('uv');
+
+const { StreamPipe } = internalBinding('stream_pipe');
+const { _connectionListener: httpConnectionListener } = http;
+const debug = util.debuglog('http2');
+
+const kMaxFrameSize = (2 ** 24) - 1;
+const kMaxInt = (2 ** 32) - 1;
+const kMaxStreams = (2 ** 31) - 1;
+
+// eslint-disable-next-line no-control-regex
+const kQuotedString = /^[\x09\x20-\x5b\x5d-\x7e\x80-\xff]*$/;
+
const { constants, nameForErrorCode } = binding;
const NETServer = net.Server;
const TLSServer = tls.Server;
-const { kIncomingMessage } = require('_http_common');
-const { kServerResponse } = require('_http_server');
-
const kAlpnProtocol = Symbol('alpnProtocol');
const kAuthority = Symbol('authority');
const kEncrypted = Symbol('encrypted');
@@ -2815,13 +2818,13 @@ function getUnpackedSettings(buf, options = {}) {
// Exports
module.exports = {
+ connect,
constants,
+ createServer,
+ createSecureServer,
getDefaultSettings,
getPackedSettings,
getUnpackedSettings,
- createServer,
- createSecureServer,
- connect,
Http2Session,
Http2Stream,
Http2ServerRequest,