diff options
| author | Masashi Hirano <cherrydog07@gmail.com> | 2018-06-21 13:02:54 +0900 |
|---|---|---|
| committer | Сковорода Никита Андреевич <chalkerx@gmail.com> | 2018-07-10 20:01:11 +0300 |
| commit | f54958ef2f6f66213f300f4fd2322e8d8c802e28 (patch) | |
| tree | 189c0b83e81e2df9bb245c12603e987c320f7ac4 /lib | |
| parent | 094346c95527f11134ddac4d0dc29e18a785bde8 (diff) | |
| download | android-node-v8-f54958ef2f6f66213f300f4fd2322e8d8c802e28.tar.gz android-node-v8-f54958ef2f6f66213f300f4fd2322e8d8c802e28.tar.bz2 android-node-v8-f54958ef2f6f66213f300f4fd2322e8d8c802e28.zip | |
fs: fix fsPromises.lchmod error on non-Mac
On non-macOS, fsPromises.lchmod throws AssertionError.
Expected behavior is `Error [ERR_METHOD_NOT_IMPLEMENTED]`.
`ERR_METHOD_NOT_IMPLEMENTED()` requires argument, but it wasn't set.
Fixes `ERR_METHOD_NOT_IMPLEMENTED()` to
`ERR_METHOD_NOT_IMPLEMENTED('lchmod()')`.
PR-URL: https://github.com/nodejs/node/pull/21435
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Diffstat (limited to 'lib')
| -rw-r--r-- | lib/internal/fs/promises.js | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/lib/internal/fs/promises.js b/lib/internal/fs/promises.js index bf8a1f2f6a..fac430bbe2 100644 --- a/lib/internal/fs/promises.js +++ b/lib/internal/fs/promises.js @@ -371,7 +371,7 @@ async function chmod(path, mode) { async function lchmod(path, mode) { if (O_SYMLINK === undefined) - throw new ERR_METHOD_NOT_IMPLEMENTED(); + throw new ERR_METHOD_NOT_IMPLEMENTED('lchmod()'); const fd = await open(path, O_WRONLY | O_SYMLINK); return fchmod(fd, mode).finally(fd.close.bind(fd)); |