diff options
author | Jon Moss <me@jonathanmoss.me> | 2018-08-03 11:23:26 -0400 |
---|---|---|
committer | Jon Moss <me@jonathanmoss.me> | 2018-08-14 11:34:34 -0400 |
commit | 3e44b8c91ef717913364ac67a12cb7cd638630db (patch) | |
tree | 885c6798245c7522a1d0f31bc76945bdcaa2afa5 /lib/internal/timers.js | |
parent | 682f9b4709f0d7e634568209ce3adfe18e345774 (diff) | |
download | android-node-v8-3e44b8c91ef717913364ac67a12cb7cd638630db.tar.gz android-node-v8-3e44b8c91ef717913364ac67a12cb7cd638630db.tar.bz2 android-node-v8-3e44b8c91ef717913364ac67a12cb7cd638630db.zip |
lib: extract validateNumber validator
Pulls out another common argument validator to `internal/validators`
PR-URL: https://github.com/nodejs/node/pull/22249
Reviewed-By: Bryan English <bryan@bryanenglish.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Diffstat (limited to 'lib/internal/timers.js')
-rw-r--r-- | lib/internal/timers.js | 7 |
1 files changed, 2 insertions, 5 deletions
diff --git a/lib/internal/timers.js b/lib/internal/timers.js index c7d9d1750e..093284a80d 100644 --- a/lib/internal/timers.js +++ b/lib/internal/timers.js @@ -12,10 +12,10 @@ const async_id_symbol = Symbol('asyncId'); const trigger_async_id_symbol = Symbol('triggerId'); const { - ERR_INVALID_ARG_TYPE, ERR_INVALID_CALLBACK, ERR_OUT_OF_RANGE } = require('internal/errors').codes; +const { validateNumber } = require('internal/validators'); // Timeout values > TIMEOUT_MAX are set to 1. const TIMEOUT_MAX = 2 ** 31 - 1; @@ -126,10 +126,7 @@ function setUnrefTimeout(callback, after, arg1, arg2, arg3) { // Type checking used by timers.enroll() and Socket#setTimeout() function validateTimerDuration(msecs) { - if (typeof msecs !== 'number') { - throw new ERR_INVALID_ARG_TYPE('msecs', 'number', msecs); - } - + validateNumber(msecs, 'msecs'); if (msecs < 0 || !isFinite(msecs)) { throw new ERR_OUT_OF_RANGE('msecs', 'a non-negative finite number', msecs); } |