From 3e44b8c91ef717913364ac67a12cb7cd638630db Mon Sep 17 00:00:00 2001 From: Jon Moss Date: Fri, 3 Aug 2018 11:23:26 -0400 Subject: lib: extract validateNumber validator Pulls out another common argument validator to `internal/validators` PR-URL: https://github.com/nodejs/node/pull/22249 Reviewed-By: Bryan English Reviewed-By: Richard Lau Reviewed-By: James M Snell Reviewed-By: Colin Ihrig Reviewed-By: Trivikram Kamat --- lib/internal/timers.js | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) (limited to 'lib/internal/timers.js') diff --git a/lib/internal/timers.js b/lib/internal/timers.js index c7d9d1750e..093284a80d 100644 --- a/lib/internal/timers.js +++ b/lib/internal/timers.js @@ -12,10 +12,10 @@ const async_id_symbol = Symbol('asyncId'); const trigger_async_id_symbol = Symbol('triggerId'); const { - ERR_INVALID_ARG_TYPE, ERR_INVALID_CALLBACK, ERR_OUT_OF_RANGE } = require('internal/errors').codes; +const { validateNumber } = require('internal/validators'); // Timeout values > TIMEOUT_MAX are set to 1. const TIMEOUT_MAX = 2 ** 31 - 1; @@ -126,10 +126,7 @@ function setUnrefTimeout(callback, after, arg1, arg2, arg3) { // Type checking used by timers.enroll() and Socket#setTimeout() function validateTimerDuration(msecs) { - if (typeof msecs !== 'number') { - throw new ERR_INVALID_ARG_TYPE('msecs', 'number', msecs); - } - + validateNumber(msecs, 'msecs'); if (msecs < 0 || !isFinite(msecs)) { throw new ERR_OUT_OF_RANGE('msecs', 'a non-negative finite number', msecs); } -- cgit v1.2.3