summaryrefslogtreecommitdiff
path: root/lib/internal/fs
diff options
context:
space:
mode:
authorGiorgos Ntemiris <ntemirisgiorgos3@gmail.com>2019-08-19 21:03:21 +0200
committerRich Trott <rtrott@gmail.com>2019-08-22 22:51:30 -0700
commiteeea3fb91b8dd177cf284a9cf7de0aec008c4e84 (patch)
treeb119a0d4c7d5bd57f870301520ccae66abc66c0a /lib/internal/fs
parentceace1f96eb0862a2944bc38c2e897974169f622 (diff)
downloadandroid-node-v8-eeea3fb91b8dd177cf284a9cf7de0aec008c4e84.tar.gz
android-node-v8-eeea3fb91b8dd177cf284a9cf7de0aec008c4e84.tar.bz2
android-node-v8-eeea3fb91b8dd177cf284a9cf7de0aec008c4e84.zip
fs: allow passing true to emitClose option
Allow passing true for emitClose option for fs streams. Fixes: https://github.com/nodejs/node/issues/29177 PR-URL: https://github.com/nodejs/node/pull/29212 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Diffstat (limited to 'lib/internal/fs')
-rw-r--r--lib/internal/fs/streams.js8
1 files changed, 6 insertions, 2 deletions
diff --git a/lib/internal/fs/streams.js b/lib/internal/fs/streams.js
index 87d58a8be5..d51fbb1b58 100644
--- a/lib/internal/fs/streams.js
+++ b/lib/internal/fs/streams.js
@@ -61,7 +61,9 @@ function ReadStream(path, options) {
options.highWaterMark = 64 * 1024;
// For backwards compat do not emit close on destroy.
- options.emitClose = false;
+ if (options.emitClose === undefined) {
+ options.emitClose = false;
+ }
Readable.call(this, options);
@@ -237,7 +239,9 @@ function WriteStream(path, options) {
options = copyObject(getOptions(options, {}));
// For backwards compat do not emit close on destroy.
- options.emitClose = false;
+ if (options.emitClose === undefined) {
+ options.emitClose = false;
+ }
Writable.call(this, options);